Closed Bug 869973 Opened 12 years ago Closed 12 years ago

mach should ignore Finder processes for other users

Categories

(Firefox Build System :: General, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 870168

People

(Reporter: standard8, Unassigned)

References

Details

I've a user that is set up as a non-admin on my mac, and that user is where I tend to do all my development work. If I try and run Mac, it gives me a permissions error, unless I do sudo (which obviously isn't a good idea). From the output, I suspect this is a regression from bug 844204. $ ./mozilla/mach build Error running mach: ['build'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: AccessDenied: (pid=145, name='Finder') File "/Users/moztest/comm/main/src/mozilla/python/mozbuild/mozbuild/mach_commands.py", line 87, in build finder_start_cpu = self._get_finder_cpu_usage() File "/Users/moztest/comm/main/src/mozilla/python/mozbuild/mozbuild/mach_commands.py", line 197, in _get_finder_cpu_usage return proc.get_cpu_times() File "/Users/moztest/comm/main/src/mozilla/python/psutil/psutil/__init__.py", line 526, in get_cpu_times return self._platform_impl.get_cpu_times() File "/Users/moztest/comm/main/src/mozilla/python/psutil/psutil/_psosx.py", line 122, in wrapper raise AccessDenied(self.pid, self._process_name)
Oh interesting. You are the first person to encounter this. I reckon something about your OS X is different. On my 10.8 machine, /System/Library/CoreServices/Finder.app/Contents/MacOS/Finder is running as my account (gps) - the primary user account on the machine. Do you have a separate user owning that process? Do you have multiple Finder processes? Please detail what's going on!
Flags: needinfo?(mbanner)
I have two users: mark - my main account, an admin moztest - my test account, which is a 'standard' account. There's two finder processes running, one for each of these. Google also turned up some info: http://code.google.com/p/psutil/wiki/Documentation http://code.google.com/p/psutil/issues/detail?id=108 http://code.google.com/p/psutil/issues/detail?id=254
Flags: needinfo?(mbanner)
This is simply a permissions problem. User A cannot access properties of a process belonging to user B. The solution is simple: ignore Finder processes not belonging to the current user. Code is at https://hg.mozilla.org/mozilla-central/file/e19d0885977c/python/mozbuild/mozbuild/mach_commands.py#l175 if anyone wants to take this.
Summary: Can't run mach in non-admin/privileged mode → mach should ignore Finder processes for other users
How is it 2 people file the same bug for the same issue that's been present for over a month within hours of one another? Any way, the other bug has a patch, so duping this one.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.