Closed Bug 870051 Opened 6 years ago Closed 6 years ago

js/src/vm/Stack.h:334:17: warning: inline function 'bool js::AbstractFramePtr::hasPushedSPSFrame() const' used but never defined [enabled by default], when building jsprobes.cpp

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dholbert, Assigned: djvj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Newish gcc build warning in js:
{
In file included from /scratch/work/builds/mozilla-inbound/mozilla/js/src/jscntxt.h:40:0,
                 from /scratch/work/builds/mozilla-inbound/mozilla/js/src/jsprobes.h:15,
                 from /scratch/work/builds/mozilla-inbound/mozilla/js/src/jsprobes.cpp:7:
/scratch/work/builds/mozilla-inbound/mozilla/js/src/vm/Stack.h:334:17: warning: inline function 'bool js::AbstractFramePtr::hasPushedSPSFrame() const' used but never defined [enabled by default]
     inline bool hasPushedSPSFrame() const;
                 ^
}

I'm using GCC 4.8.
Blocks: buildwarning
Introduced by https://hg.mozilla.org/mozilla-central/rev/6e0956c0dfe4
{
changeset:   130738:6e0956c0dfe4
user:        Kannan Vijayan <kvijayan@mozilla.com>
date:        Fri May 03 11:26:38 2013 -0400
summary:     Bug 865471 - Fix various sps profiler issues. r=jandem
}
Blocks: 865471
Attached patch Fix?Splinter Review
Daniel - I can't test this locally because my build machine is not using that version of gcc.  Can you check this out and see if it eliminates the warning?
Attachment #747082 - Flags: review?(dholbert)
I don't think this is a 4.8-specific warning, but I suppose it's possible. Regardless: happy to test & thanks for the quick action. :)  I'll report back soon
You're right, the warning does show up on my build too, and it goes away with the patch.
Comment on attachment 747082 [details] [diff] [review]
Fix?

Fixes it for me, too -- woot!

I don't normally review JS stuff, but this is trivial enough and adheres to my memory of JS conventions (inline-definition-headers #included at the end, and only in .cpp files) that I'm happy to r+.
Attachment #747082 - Flags: review?(dholbert) → review+
Assignee: general → kvijayan
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c36615f13b0e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.