Closed Bug 870060 Opened 11 years ago Closed 3 years ago

[meta] Make PromptService usages asynchronous

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: jchen, Unassigned)

References

Details

(Keywords: meta)

Attachments

(1 obsolete file)

Using the PromptService requires spinning our own event loop and is prone to causing ANRs (bug 860879). Many instances where PromptService is used can be made asynchronous.
Depends on: 870062
Depends on: 870063
Depends on: 872137
Depends on: 872142
Depends on: 872143
Depends on: 872147
Depends on: 872149
Depends on: 877200
Attached patch Patch (obsolete) — Splinter Review
Trying to bring some new people's into this code. This ports the promptService to use Prompt.jsm (i.e. async). Because HTML prompts are NOT async, we have to do a trick to spin the thread they are running on. This uses the same trick that the desktop tab-modal prompts use:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/src/nsPrompter.js#419
Attachment #756261 - Flags: review?(margaret.leibovic)
I realize now this is a metabug. Let me move that patch to something better....
Blocks: 877911
No longer blocks: 877911
Depends on: 877911
Attachment #756261 - Attachment is obsolete: true
Attachment #756261 - Flags: review?(margaret.leibovic)
Depends on: 878848
Keywords: meta
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: