Closed Bug 870073 Opened 6 years ago Closed 6 years ago

relative path to mozconfig isn't remembered

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: joe, Assigned: mbrubeck)

References

Details

Attachments

(1 file, 1 obsolete file)

I regularly build with something like

 $ MOZCONFIG=.mozconfig-android mach build

When I then subsequently try to do a sub-build, eg from objdir-android

 $ mach build image

mach then complains that it can't find .mozconfig-android.

The full path should probably be stored in wherever mach finds its mozconfigs.
Assignee: nobody → mbrubeck
Blocks: 840588
OS: Mac OS X → All
Hardware: x86 → All
Attached patch patch (obsolete) — Splinter Review
Note: I removed the |if "TOPSRCDIR" in env| check because configure.in explicitly sets TOPSRCDIR when running writemozinfo.py.
Attachment #747526 - Flags: review?(gps)
Comment on attachment 747526 [details] [diff] [review]
patch

Review of attachment 747526 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #747526 - Flags: review?(gps) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/31ff9550fba6

Note: This will not fix existing objdirs until the next time configure runs.
Status: NEW → ASSIGNED
Attached patch patch v2Splinter Review
Whoops, sorry.  :(  Now with PASSING TESTS!
Attachment #747526 - Attachment is obsolete: true
Attachment #747615 - Flags: review?(gps)
Attachment #747615 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/69185af5841e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
I'm not really wild about jamming paths into mozinfo. :-/ We expose the contents of mozinfo wholesale to the xpcshell manifest expression evaluator.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #7)
> I'm not really wild about jamming paths into mozinfo. :-/ We expose the
> contents of mozinfo wholesale to the xpcshell manifest expression evaluator.

We could fairly easily move these into a separate file in the objdir, though people who have "installed" the mach script (bug 840588) would need to upgrade it.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.