870078 - Fake touch events helper on desktop breaks scripted clicks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Eitan Isaacson [:eeejay]]

An app may want to activate an item in a scripted fashion. This is typically done with a click event, which is the de-facto activation event and has been divorced from the mouse device metaphor. This is also how our accessibility engine activates controls.

The solution is to allow mouse events with the a mozInputSource of MOZ_SOURCE_UNKNOWN through unmodified.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Ignore scripted mouse events in desktop helper TouchEventHandler.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 747102 [details] [diff] [review]
Ignore scripted mouse events in desktop helper TouchEventHandler.

Review of attachment 747102 [details] [diff] [review]:
-----------------------------------------------------------------

I don't really know enough about the inner workings of the accessibility stuff, but wouldn't you want to use the touch events to activate elements?

In any case, I tested this out and everything seems to work fine - it's low enough risk that we can go ahead and land it.

Comment 3

[Eitan Isaacson [:eeejay]]

Pull request:
https://github.com/mozilla-b2g/gaia/pull/9646

(In reply to Kevin Grandon :kgrandon from comment #2)
> Comment on attachment 747102 [details] [diff] [review]
> Ignore scripted mouse events in desktop helper TouchEventHandler.
> 
> Review of attachment 747102 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't really know enough about the inner workings of the accessibility
> stuff, but wouldn't you want to use the touch events to activate elements?
> 

Actually, their should be a device agnostic standard way of activating a widget, they tried that with DOMActivate and that failed. So |click| is considered the standard activation event, you could expect to see more patches in the future that add click listeners in gaia :)

Here is some context:
http://lists.w3.org/Archives/Public/public-hypertext-cg/2010JanMar/0001.html
http://dev.w3.org//2006/webapi/DOM-Level-3-Events/html/DOM3-Events.html#click-synthesis

Comment 4

[Eitan Isaacson [:eeejay]]

master: 768d0f0

Comment 5

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/768d0f0db2410008f5912904b51743f96b2f875b

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 747102 [details] [diff] [review]
Ignore scripted mouse events in desktop helper TouchEventHandler.

Regression introduced by bug 863422 that has already been uplifted.

Requesting uplift as we would like to have all of the developer tools/productivity related things uplifted. It also has zero impact to gaia builds as all changes are external to application code.

Comment 7

[Alexandre Poirot [:ochameau]]

v1-train: a8a58acb551f9bbd1c855d4a64e1c124d7021fd2