hacks.mozilla.org: change push script from svn to git

RESOLVED FIXED

Status

Infrastructure & Operations
WebOps: Other
P1
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: groovecoder, Assigned: cturra)

Tracking

Details

(Whiteboard: [push interrupt])

(Reporter)

Description

5 years ago
We do our work on the hacks.mozilla.org theme at https://github.com/mozilla/mozhacks/tree/master now.

We should change the push script to deploy the theme files from there instead of SVN.
(Assignee)

Comment 1

5 years ago
currently the entire wp-content directory is managed through svn. 

  http://svn.mozilla.org/projects/hacks.mozilla.org/trunk/wp-content/


due to a conflict in names, this will cause us some issues with shared svn/git repos. would it be possible to rename your Hacks2010 theme in github to something different? maybe Hacks2013?
Assignee: server-ops-webops → cturra
Flags: needinfo?(lcrouch)
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [push interrupt]
(Reporter)

Comment 2

5 years ago
I defer to Craig - not sure if WordPress installs themes based on directory names?
Flags: needinfo?(lcrouch) → needinfo?(craigcook.bugz)
(In reply to Luke Crouch [:groovecoder] from comment #2)
> I defer to Craig - not sure if WordPress installs themes based on directory
> names?

It does. Renaming the directory would just treat this as a separate theme, which is perfectly fine. We'll want to update the name in style.css as well. Then just do a push to deploy the "new" Hacks2013 theme and activate it on dev/stage/prod since Hacks2010 would still be there. Sounds like a plan to me.

That way any future fixes would happen in Hacks2013 on git and the Hacks2010 theme can be retired.

In the near future there'll be a fully redesigned theme, which should start in a new folder with a different name when the time comes.
Flags: needinfo?(craigcook.bugz)
I filed https://github.com/mozilla/mozhacks/pull/12 yesterday for the renaming, so once that's merged I think we'll be all set to flip the switch.
(Reporter)

Comment 5

5 years ago
We have to flip two switches here, right? 1. Merge that code 2. change the push script to use git. And we need to flip them in that order? Are there any outstanding mozhacks pull requests we should merge and push BEFORE we change this stuff up?
(In reply to Luke Crouch [:groovecoder] from comment #5)
> We have to flip two switches here, right? 1. Merge that code 2. change the
> push script to use git. And we need to flip them in that order? 

Yeah, I think we need to do the renaming before we can update the deployment script, definitely before we actually try to RUN the deployment script.

> Are there any outstanding mozhacks pull requests we should merge and 
> push BEFORE we change this stuff up?

No other PRs currently. Davidwalsh had one for adding IDs to the author list but I merged that already. It hasn't been pushed yet so it will be part of the first push from git.
(Reporter)

Comment 7

5 years ago
Merged https://github.com/mozilla/mozhacks/pull/12.

We need to test this on dev/stage first. And make sure we *don't* clear out what's already in place from SVN - we just want to add the Hacks2013 theme from git.
(Assignee)

Comment 8

5 years ago
i have created a seperate wp-content directory, which contains the Hacks2013 theme and symlinked it into place. 

[root@generic1.dev.webapp.phx1 themes]# ls -l Hacks2013
lrwxrwxrwx 1 root root 37 May 21 13:52 Hacks2013 -> ../../wp-content-git/themes/Hacks2013

additionally, i have updated the `update` script to do git fetch from origin/master on github/mozhacks. 

please give this a test in dev and let me know when you want this same change pushed to stage.
Flags: needinfo?(lcrouch)
(Reporter)

Comment 9

5 years ago
I don't have the admin user/pw for hacks-dev.allizom.org. Can someone send it to me?
Flags: needinfo?(lcrouch) → needinfo?(cturra)
(Reporter)

Updated

5 years ago
Priority: -- → P1
(Assignee)

Comment 10

5 years ago
i didn't have a login either, which was actually why i was hoping you could help test for me. according to the wp_user table in the database you do have one:

 mysql> select user_login,user_email from wp_users where user_login='groovecoder'\G
 *************************** 1. row ***************************
 user_login: groovecoder
 user_email: lcrouch@mozilla.com
 1 row in set (0.00 sec)


:groovecoder - could you please help track down someone that does indeed have access to -dev for us?
Flags: needinfo?(cturra)
(Reporter)

Comment 11

5 years ago
yup, I found it. dev looks good. let's try stage.
(Assignee)

Comment 12

5 years ago
(In reply to Luke Crouch [:groovecoder] from comment #11)
> yup, I found it. dev looks good. let's try stage.

i have pushed this to stage now and :craigcook got me access to the environment to enable the theme for you. please go ahead and give it a review.
Flags: needinfo?(lcrouch)
(Reporter)

Comment 13

5 years ago
worksforme. I'm ready to try prod now.
Flags: needinfo?(lcrouch)
(Assignee)

Comment 14

5 years ago
i have pushed this change to prod as requested, but will leave it up to you fine folks to enable the new theme.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 15

5 years ago
I switched it over and it's working fine: https://hacks.mozilla.org/

So now the hacks push script pulls from the github repo now, right? We've got a PR pending to it: https://github.com/mozilla/mozhacks/pull/13
Component: Server Operations: Web Operations → WebOps: Other
Product: mozilla.org → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.