Open Bug 870108 Opened 12 years ago Updated 3 years ago

Factory::CreateWrappingDataSourceSurface considered harmful?

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect

Tracking

()

People

(Reporter: snorp, Unassigned)

Details

I tried to use Factory::CreateWrappingDataSourceSurface to draw some bits to a DrawTarget. It crashed, however, in spite of the aforementioned returning a seemingly valid DataSourceSurface. It turns out that at least DrawTargetCG expects SourceSurface instances to be like DataSourceSurfaceCG, etc, and not whatever Factory::CreateWrappingDataSourceSurface returns. Also, I noticed we have DrawTarget::CreateSourceSurfaceFromData which does the exact same thing except works. Can we please remove the Factory method?
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.