Closed Bug 870120 Opened 7 years ago Closed 7 years ago
Segments Info no longer working with new MMS compatible composer
_mozMobileMessage.maxSegmentsInfo no longer working with new MMS compatible composer - this should be mocked in tests and have tests written to verify its operation.
Priority: -- → P1
Target Milestone: --- → 1.1 CS (11may)
this was raised from https://github.com/mozilla-b2g/gaia/pull/9385#issuecomment-17627296
The max-lenght is not working, so you can type more text if you want despite of reaching the max number of characters.
Here we have 2 things to fix: - Fix Tests - Fix the max-lenght issue
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 870124
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Whiteboard: dev-branch [NO_UPLIFT] → [NO_UPLIFT]
The max length work should be removed with the MMS stuff anyway, that was the plan from the start. With MMS, AFAIK we should not prevent the user from adding more characters and convert the message to MMS instead, so this is a completely different use case, and should be done again from the ground up. As I said, this was the plan.
> With MMS, AFAIK we should not prevent the user from adding more characters > and convert the message to MMS instead, True.
Comment on attachment 748301 [details] [diff] [review] https://github.com/bocoup/gaia/pull/11 r+ for this patch, but consider whether you could just switch the keydown handler to keypress. I also wonder whether the composeLockCheck() function should actually set locked to false, or if it should just leave that for the composeCheck() function to do. (Unless no 'input' event is generated on backspace.)
Attachment #748301 - Flags: review?(fbsc) → review+
Whiteboard: [NO_UPLIFT] → [NO_UPLIFT] dev-branch
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Whiteboard: [NO_UPLIFT] dev-branch → [NO_UPLIFT]
You need to log in before you can comment on or make changes to this bug.