870120 - [SMS] maxSegmentsInfo no longer working with new MMS compatible composer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Dan Heberden]

_mozMobileMessage.maxSegmentsInfo no longer working with new MMS compatible composer - this should be mocked in tests and have tests written to verify its operation.

Comment 1

[Dan Heberden]

related: https://bugzilla.mozilla.org/show_bug.cgi?id=865411

Comment 2

[Dan Heberden]

this was raised from https://github.com/mozilla-b2g/gaia/pull/9385#issuecomment-17627296

Comment 3

[Borja Salguero [:borjasalguero]]

Attachment: maxSegments not working

The max-lenght is not working, so you can type more text if you want despite of reaching the max number of characters.

Comment 4

[Borja Salguero [:borjasalguero]]

Here we have 2 things to fix:
- Fix Tests
- Fix the max-lenght issue

Comment 6

[Borja Salguero [:borjasalguero]]

Attachment: Currently in bocoup branch.

Comment 7

[Corey Frang [:gnarf]]

Attachment: https://github.com/bocoup/gaia/pull/11

Comment 8

[Julien Wajsberg [:julienw]]

The max length work should be removed with the MMS stuff anyway, that was the plan from the start.

With MMS, AFAIK we should not prevent the user from adding more characters and convert the message to MMS instead, so this is a completely different use case, and should be done again from the ground up.

As I said, this was the plan.

Comment 9

[ayman maat :maat]

> With MMS, AFAIK we should not prevent the user from adding more characters
> and convert the message to MMS instead, 

True.

Comment 10

[David Flanagan [:djf]]

Comment on attachment 748301 [details] [diff] [review]
https://github.com/bocoup/gaia/pull/11

r+ for this patch, but consider whether you could just switch the keydown handler to keypress.

I also wonder whether the composeLockCheck() function should actually set locked to false, or if it should just leave that for the composeCheck() function to do.  (Unless no 'input' event is generated on backspace.)

Comment 11

[Corey Frang [:gnarf]]

https://github.com/mozilla-b2g/gaia/commit/ac229186a02a05e1e0cd998fff0ad7511bf30a63

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 5c6a147