870124 - [MMS][User Interface] SMS counter display

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Dan Heberden]

The SMS counter/message-count display is no longer styled properly with the MMS compatible composition area and new layout.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Counter styles broken

Comment 2

[Borja Salguero [:borjasalguero]]

This patch should restore the original CSS styles following https://www.dropbox.com/sh/8jkb0osnvfda96e/TkcQuTbhHj#f:01.SMS.MMS_0006_Compose_Longmessage.png

Comment 3

[greg]

Attachment: Pull Request

Comment 5

[greg]

Just waiting for review from :rnowm per :borjasalguero

Comment 6

[Borja Salguero [:borjasalguero]]

Here we have to ways:
- Wait to :rnowm due to we are changing the layout, and we could keep the previous one.
- Keep the layout as it is and I will review your code asap.

Comment 7

[Borja Salguero [:borjasalguero]]

Attachment: Counter with new patch. Needs UX input.

Comment 8

[Victoria Gerchinhoren [:vicky]]

Attachment: indications on how must the counter be aligned

Comment 9

[Julien Wajsberg [:julienw]]

If I'm not mistaken, this landed on bocoup's dev branch. Please add a whiteboard comment, and put the commit url here. Thanks

Comment 10

[Corey Frang [:gnarf]]

https://github.com/mozilla-b2g/gaia/commit/9ef20d89bd64e6ba3516b0675e357da0cc3cc4e8

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train:5896863

Comment 12

[sbogati]

Issue no longer repros on Leo device
Build ID: 20130809041203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/45480132106b
Gaia: c9d0901564cf6f50e375ab48e4124b8378a2e246
Platform Version: 18.1
SMS counter displaying as expected.