Contacts import from SIM card blocks

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: volker.mische, Assigned: volker.mische)

Tracking

({regression})

unspecified
regression
Bug Flags:
in-testsuite +
in-moztrap +

Firefox Tracking Flags

(blocking-b2g:leo+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Details

(Whiteboard: [fixed-in-birch], URL)

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 747180 [details] [diff] [review]
sim-import-without-phone-number-fix.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.68 Safari/537.17

Steps to reproduce:

I imported contacts from my SIM card


Actual results:

It stopped after a few were imported


Expected results:

All contacts should've been imported
(Assignee)

Comment 1

6 years ago
It's on my Geeksphone Peak. I've installed a fresh master checkout yesterday. The attached patch fixes the problem for me.

The issue was, that I had a contact that haven't had a phone number specified. It lead to the following error:

E/GeckoConsole(  528): [JavaScript Error: "aContact.properties.tel[(intermediate value)].value is undefined" {file: "resource://gre/modules/ContactDB.jsm" line: 458}]
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → volker.mische
Nominating as this seems pretty important
blocking-b2g: --- → tef?
(Assignee)

Comment 3

6 years ago
I was asked on IRC to add a test case. I'll do that. I just need to get Gecko built (which I don't know how long it'll take me) in order to run mochitests.
Geeksphone Peak does not have the commercial RIL but the opensource one. I think we need to check if this is happening with the Commercial one before blocking on this one.

Can we get more information about SIM Content and Gaia/Gecko versions of the device?
Flags: needinfo?(volker.mische)
(Assignee)

Comment 5

6 years ago
It doesn't happen with the stock version that is preinstalled on the Peak. It only happened when I flashed it with a nightly build of B2G.
Flags: needinfo?(volker.mische)
This bug was introduced on bug 866135 which hasn't (and won't) land on 1.0.1. So this one should be leo+ not tef+.
Attachment #747180 - Flags: review+
Created attachment 749348 [details] [diff] [review]
tests and fix mail
Attachment #749348 - Flags: review?(reuben.bmo)
Thanks Volker!
Attachment #749348 - Flags: review?(reuben.bmo) → review+
(Assignee)

Comment 9

6 years ago
Thanks for the tests Gregor.
Thanks for the patch!

https://hg.mozilla.org/projects/birch/rev/5b763f3b244d
https://hg.mozilla.org/projects/birch/rev/bcaf8ff17932

Flagging for leo? instead, see comment 6.
blocking-b2g: tef? → leo?
Whiteboard: [fixed-in-birch]
https://hg.mozilla.org/mozilla-central/rev/5b763f3b244d
https://hg.mozilla.org/mozilla-central/rev/bcaf8ff17932
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED

Updated

6 years ago
blocking-b2g: leo? → leo+
Keywords: regression
https://hg.mozilla.org/releases/mozilla-b2g18/rev/0684deeae204
https://hg.mozilla.org/releases/mozilla-b2g18/rev/a5c3ba754674

The second patch required a little tweaking to apply, FWIW.
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
status-firefox22: --- → wontfix
status-firefox23: --- → wontfix
status-firefox24: --- → fixed

Updated

6 years ago
Flags: in-moztrap?
Landed a followup to fix a part that went missing in the rebase:
https://hg.mozilla.org/releases/mozilla-b2g18/rev/82f1dfb84097
(In reply to Reuben Morais [:reuben] from comment #13)
> Landed a followup to fix a part that went missing in the rebase:
> https://hg.mozilla.org/releases/mozilla-b2g18/rev/82f1dfb84097

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/82f1dfb84097
status-b2g-v1.1hd: --- → fixed

Updated

6 years ago
Flags: in-moztrap? → in-moztrap+
QA Contact: amiller
You need to log in before you can comment on or make changes to this bug.