870148 - Contacts import from SIM card blocks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[volker.mische]

Attachment: sim-import-without-phone-number-fix.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.68 Safari/537.17

Steps to reproduce:

I imported contacts from my SIM card


Actual results:

It stopped after a few were imported


Expected results:

All contacts should've been imported

Comment 1

[volker.mische]

It's on my Geeksphone Peak. I've installed a fresh master checkout yesterday. The attached patch fixes the problem for me.

The issue was, that I had a contact that haven't had a phone number specified. It lead to the following error:

E/GeckoConsole(  528): [JavaScript Error: "aContact.properties.tel[(intermediate value)].value is undefined" {file: "resource://gre/modules/ContactDB.jsm" line: 458}]

Comment 2

[Dale Harvey (:daleharvey)]

Nominating as this seems pretty important

Comment 3

[volker.mische]

I was asked on IRC to add a test case. I'll do that. I just need to get Gecko built (which I don't know how long it'll take me) in order to run mochitests.

Comment 4

[Daniel Coloma:dcoloma]

Geeksphone Peak does not have the commercial RIL but the opensource one. I think we need to check if this is happening with the Commercial one before blocking on this one.

Can we get more information about SIM Content and Gaia/Gecko versions of the device?

Comment 5

[volker.mische]

It doesn't happen with the stock version that is preinstalled on the Peak. It only happened when I flashed it with a nightly build of B2G.

Comment 6

[Antonio Manuel Amaya Calvo (:amac)]

This bug was introduced on bug 866135 which hasn't (and won't) land on 1.0.1. So this one should be leo+ not tef+.

Comment 7

[Gregor Wagner [:gwagner]]

Attachment: tests and fix mail

Comment 8

[Gregor Wagner [:gwagner]]

Thanks Volker!

Comment 9

[volker.mische]

Thanks for the tests Gregor.

Comment 10

[Reuben Morais [:reuben]]

Thanks for the patch!

https://hg.mozilla.org/projects/birch/rev/5b763f3b244d
https://hg.mozilla.org/projects/birch/rev/bcaf8ff17932

Flagging for leo? instead, see comment 6.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b763f3b244d
https://hg.mozilla.org/mozilla-central/rev/bcaf8ff17932

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/0684deeae204
https://hg.mozilla.org/releases/mozilla-b2g18/rev/a5c3ba754674

The second patch required a little tweaking to apply, FWIW.

Comment 13

[Reuben Morais [:reuben]]

Landed a followup to fix a part that went missing in the rebase:
https://hg.mozilla.org/releases/mozilla-b2g18/rev/82f1dfb84097

Comment 14

[Ryan VanderMeulen [:RyanVM]]

(In reply to Reuben Morais [:reuben] from comment #13)
> Landed a followup to fix a part that went missing in the rebase:
> https://hg.mozilla.org/releases/mozilla-b2g18/rev/82f1dfb84097

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/82f1dfb84097