Closed
Bug 870183
Opened 12 years ago
Closed 12 years ago
IonMonkey: Support three-form infallible ADD via LEA.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: sstangl, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
|
7.41 KB,
patch
|
Details | Diff | Splinter Review |
Supporting LEA would decrease the number of Odin instructions by changing common patterns such as:
> movl %r12d, %r9d
> addl %eax, %r12d
to:
> leal (r12d,eax,1), %r9d
The attached patch appears to work just fine, but I'll take more time to be sure. The last case of leal() looks fairly dodgy.
|
Reporter | |
Comment 1•12 years ago
|
||
Although this works, it regresses fasta.js from 1.950s to 2.024s consistently. Other benchmarks seem at best unaffected.
Attachment #747225 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•