870186 - [Settings] Radio buttons in ringtone menu are not checked when previewing multiple ringtones

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Ringtones, defect, P3)

Description

[Leo]

1. Title : Do not check radio button in ringtone menu when play a preview sound in serveral ringtones
2. Precondition : Settings - sound - change
3. Tester's Action : change the ringtones quickly and play a preview sound
4. Detailed Symptom : Play a preview sound BUT a radio check do not update as active.
5. Expected : a radio button will be changed to active state
6. Reproducibility: Y
   - Frequency Rate : 10%~20%
7.Gaia Master/v1-train : Sometimes reproduced
8. Version Info
Gaia : 5cbb19e4bb78a7ad879fbe4b9a841e1c35714f5c
Gecko : e4a677c13bf35253fea99e6b85df1c707038d119
Mozilla build ID : 20130421070203

Comment 1

[Leo]

Attachment: video contents

Comment 2

[bhavana bajaj [:bajaj]]

Will take a low risk uplift but definitely not a blocker.

Comment 3

[Dylan Oliver [:doliver]]

Lowering priority. Difficult to reproduce (we couldn't do it in triage) and seems like an edge case.

Comment 4

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #10342 - Add timeout for sound preview

The symptoms highlighted in the description were quite hard to reproduce, however, setting a timeout for the sound preview ensures that no (wrong) sound is played if checkboxes are tapped on quickly as in the video.

Comment 5

[Evelyn Hung]

Comment on attachment 761375 [details]
Pull Request #10342 - Add timeout for sound preview

I have a quick look at this patch and suspect we don't need the 1 sec timeout value(|audioPreviewTimeout|), but just use setTimeout to force playing after CSS applying.
Redirect this review request to Arthur for a verification. Thanks, Arthur!

Comment 6

[Dylan Oliver [:doliver]]

Arthur, have you had a chance to take a look at this review yet?

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Mihai, thanks for the effort! However, I am not able to reproduce the issue. As the provided video (attachment 747254 [details]) shows, the end state is correct. Even the issue does exist, I don't think it is worthy adding additional logic to avoid it. I would like QA confirm the bug at first.

Comment 8

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Arthur Chen [:arthurcc] from comment #7)
> Mihai, thanks for the effort! However, I am not able to reproduce the issue.
> As the provided video (attachment 747254 [details]) shows, the end state is
> correct. Even the issue does exist, I don't think it is worthy adding
> additional logic to avoid it. I would like QA confirm the bug at first.

Hi Arthur, thanks for taking a look at the patch. I found it hard to reproduce as well, but adding a timeout would definitely avoid playing the wrong sound and the unpleasant glitches when quickly tapping the different sounds in the list.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

From the original video, I saw the check box was not updated in time (only in the end of the video), and the sounds were played correctly right after the user tapped them. 

If the bug does exist (check box not checked in such corner case), I would like UX designers to decide if we are going to do the trade off (by adding an one-second delay).

Comment 10

[Stephany Wilkes]

Assigning to Casey for systems front-end. Casey, feel free to reassign as necessary/appropriate.

Comment 11

[Casey Yee]

I couldn't reproduce the issue and the video doesn't seem to play in any of my browsers.

If this is indeed an issue, we should certainly fix it.   I don't think introducing a delay to solve such a edge-case is a good idea and sounds like a bit of a hack that I'd like to avoid if we can.

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Casey Yee [:cyee] from comment #11)
> I couldn't reproduce the issue and the video doesn't seem to play in any of
> my browsers.
> 
> If this is indeed an issue, we should certainly fix it.   I don't think
> introducing a delay to solve such a edge-case is a good idea and sounds like
> a bit of a hack that I'd like to avoid if we can.

Thanks for the input Casey. I think the delay for playing a sound (which is imperceptible and can even be avoided as comment 5 suggests) doesn't only avoid this edge case, but also improves the user experience by avoiding the glitches/clipping that happen when quickly switching between sounds.

I uploaded the video from the attachments to YouTube (as unlisted: only people with link can see it) so you can check it out at: http://youtu.be/__uVSlaRJII.

Comment 13

[Angela Hubenya]

Attachment: logcat

Comment 14

[Angela Hubenya]

I was able to reproduce this issue when switching between ringtones very, very quickly. The selected ringtone is not displayed as selected, and the previously selected ringtone keeps ringing. But within a split second, the selection seems to catch up.

Environmental Variables
Build ID: 20130722070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: 41d10fb10be6916e6554eb440d9a97130ef23ce0
Platform Version: 18.1
RIL Version: 01.01.00.019.164

Comment 15

[Stephany Wilkes]

Flagging Neo since Settings is his domain.

Comment 16

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Any updates on this? Does the behavior mentioned in comment 12 make sense?

Comment 17

[Neo Hsieh [:neo]]

I saw that youtube video clip, It seems no any issue there..

Comment 18

[Jim Porter (:squib)]

The ringtones app has pretty much been rewritten since this bug was filed, and I can't reproduce this. Can someone else try to confirm whether this is still an issue?

Comment 19

[Montoya Clemmons (MClemmons)]

(In reply to Jim Porter (:squib) from comment #18)
> The ringtones app has pretty much been rewritten since this bug was filed,
> and I can't reproduce this. Can someone else try to confirm whether this is
> still an issue?

Able to intermittently reproduce the issue reported in Comment 0 on Flame 2.0 June 10th build. Repeated tapping of various ringtones demonstrated intermittent preview sound playing with the radio button not being selected as active with the update. Repro rate is 10 % (10/100).

Environmental Variables:
Device: Flame
Build ID: 20140610000223
Gaia: 8d865839d932bfbd5e157f376f74d8cb12bfdd51
Gecko: 1d4046a8cb6c
Version: 32.0a2 
Firmware Version: v10G-2
User Agent:  Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 20

[Joshua Mitchell (Inactive)]

QA-Wanted requests seem complete (for now).

Comment 21

[BMO Automation]

Firefox OS is not being worked on