870214 - pymake cannot execute config/now in nsprpub

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

When building NSPR using pymake, the following log is sometimes outputed.

make.py[9]: Leaving directory 'e:\builds\moz2_slave\try-w32-0000000000000000000000\build\obj-firefox\nsprpub\pr\src\threads'
make.py[9]: Entering directory 'e:\builds\moz2_slave\try-w32-0000000000000000000000\build\obj-firefox\nsprpub\pr\src'
Error executing command ../../config/./now [Error 2] The system cannot find the file specified
Error executing command ../../config/./now [Error 2] The system cannot find the file specified

In Makefile, (nsprpub/pr/src/Makefile.in)

NOW = $(MOD_DEPTH)/config/$(OBJDIR)/now
SH_NOW = $(shell $(NOW))
...
        @$(ECHO) '#define _BUILD_STRING "$(SH_DATE)"' > $(TINC)
        @if test ! -z "$(SH_NOW)"; then \
            $(ECHO) '#define _BUILD_TIME $(SH_NOW)$(SUF)' >> $(TINC); \
        else \
            true; \
        fi

GNU make resolves now as now.exe, but pymake doesn't resolve as adding exe suffix.

Comment 1

[Makoto Kato [:m_kato]]

To resolve by nspr side, all NOW definition in Makefile modifies to now$(PROG_SUFFIX) after define PROG_SUFFIX.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 3

[Makoto Kato [:m_kato]]

Attachment: fix v2

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 770664 [details] [diff] [review]
fix v2

Review of attachment 770664 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!

Could you refactor the logic to avoid the redundant os.path.isfile() lookup?

Also, a basic test would be nice.

Comment 5

[Chris Cooper [:coop] (he/him)]

Mass close of pymake-related bugs.