Includes should go under /usr/include/mozjs-x.y

RESOLVED FIXED in mozilla24

Status

RESOLVED FIXED
5 years ago
6 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

Trunk
mozilla24

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
MODULE is not really useful per se, but it is used to determine, for example, the pkg-config file name and such. Which means that with the current value, its name is either js.pc or js-x.y.pc.

IMHO js a too generic name to claim for pkg-config, /usr/include, etc. It should be smjs or mozjs.
(Assignee)

Comment 1

5 years ago
Mmm so in fact, the pkg-config file *is* named mozjs-x.y.pc, which is even more inconsistent with js-config and /usr/include/js-x.y. These are the ones that need to change.
(Assignee)

Comment 2

5 years ago
Let's already take care of /usr/include. js-config should probably die.
Summary: MODULE in js/src/moz.build should be mozjs instead of js → Includes should go under /usr/include/mozjs-x.y
(Assignee)

Comment 3

5 years ago
Created attachment 747347 [details] [diff] [review]
Put includes under /usr/include/mozjs-x.y instead of /usr/include/js-x.y on make install
Attachment #747347 - Flags: review?(jwalden+bmo)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 4

5 years ago
Created attachment 747354 [details] [diff] [review]
Put includes under /usr/include/mozjs-x.y instead of /usr/include/js-x.y on make install

In fact, with this change we don't even need to alter MODULE anymore.
Attachment #747354 - Flags: review?(jwalden+bmo)
(Assignee)

Updated

5 years ago
Attachment #747347 - Attachment is obsolete: true
Attachment #747347 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 5

5 years ago
Comment on attachment 747354 [details] [diff] [review]
Put includes under /usr/include/mozjs-x.y instead of /usr/include/js-x.y on make install

Forget it, this is missing some things.
Attachment #747354 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 6

5 years ago
Created attachment 747389 [details] [diff] [review]
Put includes under /usr/include/mozjs-x.y instead of /usr/include/js-x.y on make install
Attachment #747389 - Flags: review?(jwalden+bmo)
(Assignee)

Updated

5 years ago
Attachment #747354 - Attachment is obsolete: true

Comment 7

5 years ago
Comment on attachment 747389 [details] [diff] [review]
Put includes under /usr/include/mozjs-x.y instead of /usr/include/js-x.y on make install

Review of attachment 747389 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but forwarding to Sean mostly so more people are aware of the state of affairs on this...
Attachment #747389 - Flags: review?(sstangl)
Attachment #747389 - Flags: review?(jwalden+bmo)
Attachment #747389 - Flags: review+

Updated

5 years ago
Attachment #747389 - Flags: review?(sstangl) → review+
https://hg.mozilla.org/mozilla-central/rev/668d1525ef29
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.