Closed Bug 870325 Opened 9 years ago Closed 9 years ago

Alignment problem in Script::data

Categories

(Core :: JavaScript Engine, defect)

Sun
NetBSD
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: martin, Unassigned)

Details

Attachments

(1 file)

On sparc64 (at least) an odd number of try notes (sized 12 byte each) may cause a misaligned pointer for the bindings array following it in common storage (size 8 byte, requires 8 byte alignment).

The attached patch seems to fix it for me.
Comment on attachment 747375 [details] [diff] [review]
Add padding before bindings array

Let's try to get feedback on this, or even review!
Attachment #747375 - Flags: review?(luke)
Comment on attachment 747375 [details] [diff] [review]
Add padding before bindings array

Fwiw, this fixes firefox on sparc64 for me too, as per bug #840242 comment 15.

Pushed to try in https://tbpl.mozilla.org/?tree=Try&rev=e62d4aee3e38
Attachment #747375 - Flags: feedback+
Comment on attachment 747375 [details] [diff] [review]
Add padding before bindings array

Forwarding to njn.
Attachment #747375 - Flags: review?(luke) → review?(n.nethercote)
Comment on attachment 747375 [details] [diff] [review]
Add padding before bindings array

Review of attachment 747375 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok, though I have some nits about the code formatting.  Do you have commit access?  If not, I'll land this and fix the nits before I do.  Thanks!
Attachment #747375 - Flags: review?(n.nethercote) → review+
I do have commit access, but wont be able to push this until this weekend.
https://hg.mozilla.org/mozilla-central/rev/88d63d06dec9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.