870325 - Alignment problem in Script::data

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Martin Husemann]

Attachment: Add padding before bindings array

On sparc64 (at least) an odd number of try notes (sized 12 byte each) may cause a misaligned pointer for the bindings array following it in common storage (size 8 byte, requires 8 byte alignment).

The attached patch seems to fix it for me.

Comment 1

[Landry Breuil (:gaston)]

Comment on attachment 747375 [details] [diff] [review]
Add padding before bindings array

Let's try to get feedback on this, or even review!

Comment 2

[Landry Breuil (:gaston)]

Comment on attachment 747375 [details] [diff] [review]
Add padding before bindings array

Fwiw, this fixes firefox on sparc64 for me too, as per bug #840242 comment 15.

Pushed to try in https://tbpl.mozilla.org/?tree=Try&rev=e62d4aee3e38

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 747375 [details] [diff] [review]
Add padding before bindings array

Forwarding to njn.

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 747375 [details] [diff] [review]
Add padding before bindings array

Review of attachment 747375 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok, though I have some nits about the code formatting.  Do you have commit access?  If not, I'll land this and fix the nits before I do.  Thanks!

Comment 5

[Landry Breuil (:gaston)]

I do have commit access, but wont be able to push this until this weekend.

Comment 6

[Nicholas Nethercote [inactive]]

Landed with minor nits addressed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/88d63d06dec9

Thanks, Martin.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88d63d06dec9