Closed Bug 870341 Opened 11 years ago Closed 11 years ago

OSX: Private Window - Double click on the toolbar doesn't minimize into the dock

Categories

(Firefox :: Private Browsing, defect)

22 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 853105

People

(Reporter: mehmet.sahin, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0
Build ID: 20130506154904

Steps to reproduce:

OSX 10.8.3
Firefox 21 Beta Channel

1.) Enable 'double click on toolbar to minimize into Dock' in OSX preferences
2.) Open a Private Window
3.) Make double click on the toolbar to minimize the Private Window into the Dock


Actual results:

It doesn't work. 


Expected results:

It should work. (It works fine with Non-Private-Window.)
Component: Untriaged → Theme
Component: Theme → Private Browsing
Version: 21 Branch → 22 Branch
Mike/Josiah, we're drawing in the titlebar on m-c for the OS X private browsing theme. Is there some quick solution to enable the doubleclick to minimize behaviour?
(In reply to Josh Matthews [:jdm] from comment #1)
> Mike/Josiah, we're drawing in the titlebar on m-c for the OS X private
> browsing theme. Is there some quick solution to enable the doubleclick to
> minimize behaviour?

The only solution currently (That I am aware of) is to disable drawing in the titlebar. Of course, for this window we need that capability to draw the purple "private" icon in the top right corner. My guess is that our OpenGL override is taking control of the button presses. We will probably need to add a mouse-click observer to our "custom" titlebar, and execute performMiniaturize: when we detect a double-click.

This bug really needs to become "Allow double-click to minimize in windows that drawInTitlebar on OS X". We will want this ability even when Australis lands (I assume), so this needs to be fixed in general anyway.

But perhaps Mike knows of some little trick that I am unaware of. If not, I could probably work on this fairly soon.
The titlebar vbox could have a dblclick event listener set on it which calls window.minimize();, but this wouldn't directly observe the "double click on toolbar to minimize into Dock" system setting. If you wanted to handle that case, you'd need a way of reading that system setting.
Also, this is very much related to 853105 - Josh, if you've no objection, I think we should dupe this to that one.
Objection overruled!
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.