870378 - do not output error messages from reboot step on android

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I have noticed a lot of the failures that we see starred related to android seem to be in the reboot step.  My assertion is that we do not care about these errors and the related starring of bugs provide no benefit.

Please present any information that I might not be aware of.  

Doing this will remove most if not all double starring that occurs on the nss shutdown crash we experience.  It will also help us focus on issues related to setting up and running tests.

Comment 1

[Ed Morley [:emorley]]

I agree that it would be good to get rid of the error line if it isn't the root cause in many causes. 

That said, I've found some runs where no other failure line is present - am I correct in thinking the "java.lang.IllegalArgumentException" / "WIN DEATH" pattern in these is the real cause? If so, we should add it to the TBPL parser or else (preferably) add support for it in mozcrash or remoteautomation.py

https://tbpl.mozilla.org/php/getParsedLog.php?id=22724423&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=22723294&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=22721902&tree=Mozilla-Inbound

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: silence the errors from sut_tool/* dm* while doing a reboot (1.0)

not tested in a production like environment, would like to get some testing in staging before deploying.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 748102 [details] [diff] [review]
silence the errors from sut_tool/* dm* while doing a reboot (1.0)

Review of attachment 748102 [details] [diff] [review]:
-----------------------------------------------------------------

::: sut_tools/sut_lib.py
@@ +443,2 @@
>      log.info(flagfile)
> +    if contents is not None and not silent:

r-, I want the actual flag to be set here, so we can bail if the device goes bad. the silent should only be for the print below.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: silence the errors from sut_tool/* dm* while doing a reboot (1.1)

got it!

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 748153 [details] [diff] [review]
silence the errors from sut_tool/* dm* while doing a reboot (1.1)

Review of attachment 748153 [details] [diff] [review]:
-----------------------------------------------------------------

land away we'll test this Monday

Comment 6

[Geoff Brown [:gbrown]]

Comment on attachment 748153 [details] [diff] [review]
silence the errors from sut_tool/* dm* while doing a reboot (1.1)

Review of attachment 748153 [details] [diff] [review]:
-----------------------------------------------------------------

::: sut_tools/sut_lib.py
@@ +548,4 @@
>      attempt = 0
>      while attempt < max_attempts:
>          attempt += 1
> +        retVal = soft_reboot(device, dm, *args, silent, **kwargs)

Inconsistent order of arguments here. Should be ..., dm, silent, *args, ...

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

checked in as well as flipping arguments from comment #6 (thanks :gbrown):
http://hg.mozilla.org/build/talos/rev/66e1bfa39d3f

Comment 8

[Justin Wood (:Callek)]

This looked good in staging, and since we had to do a deploy today for another reason I went ahead and made this live.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: fix typo we overlooked and didn't see in staging (1.0)

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

landed:
https://hg.mozilla.org/build/tools/rev/d6b3ac0de002

please deploy when you get a chance.