870421 - Merge Notes into Gaia

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[(not reading bugmail) Nick Desaulniers [:\n]]

To get the Firefox OS Notes app, which was contracted to everything.me, on the localization track, we're looking to land the code into Gaia.  Axel would like to review the patch.  Ran, from everything.me, needs to fork gaia and issue a pull request, and `git diff > patch.txt` and submit that patch as an attachment here.  We're also looking to get a bugzilla component for gaia::notes.

Comment 1

[Jason Smith [:jsmith]]

Hold up a second - I'm not sure this is the right route to go here. Speaking from QA team, it's just too late to do what's suggested here.

We need more peers from other groups to discuss this before we go forward with this. And this really late to push this into the core, as that puts our QA team on the line for testing this directly.

Comment 2

[Axel Hecht [:Pike]]

Jason, we're all on the same page here, we're very late. The place where we land this doesn't change how late we are, though, nor does it impact the risk. There's interest on this on the partner front, which is why we're making both the risks and the benefits obvious by going the route of bugs and approvals.

Note, I filed bug 870427 to get a component for the notes app, as we want to upstream this app regardless of which release we're making.

Comment 3

[[:fabrice] Fabrice Desré]

Also, we had big landings before, and this is really terrible. Please don't do that.

Comment 4

[Alex Keybl [:akeybl]]

Please don't make a blocking decision until this has played out in email and we've had the chance to discuss further.

Comment 5

[Donovan Preston [:fzzzy]]

(In reply to Fabrice Desré [:fabrice] from comment #3)
> Also, we had big landings before, and this is really terrible. Please don't
> do that.

Why is it terrible? The changes would be restricted to additions to the apps/notes directory. Can you help me understand why it would be problematic?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Donovan Preston from comment #5)
> (In reply to Fabrice Desré [:fabrice] from comment #3)
> > Also, we had big landings before, and this is really terrible. Please don't
> > do that.
> 
> Why is it terrible? The changes would be restricted to additions to the
> apps/notes directory. Can you help me understand why it would be problematic?

Let's hold on any discussion on in the bug and continue this discussion on b2g-release-drivers.

Comment 7

[[:fabrice] Fabrice Desré]

(In reply to Donovan Preston from comment #5)
> (In reply to Fabrice Desré [:fabrice] from comment #3)
> > Also, we had big landings before, and this is really terrible. Please don't
> > do that.
> 
> Why is it terrible? The changes would be restricted to additions to the
> apps/notes directory. Can you help me understand why it would be problematic?

That's too big a chunk of code to review in one pass. Every time that happened in the past, there was some product pressure to land and ignore issues. That needs to stop.

What if landing takes weeks? Is that ok?

Comment 8

[Karen Ward [:kward]]

Withrawing this request.

Comment 9

[Karen Ward [:kward]]

Withrawing this request.