870432 - Handle complete failure to load Persona

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[Kumar McMillan [:kumar]]

In the rare case that the Persona server cannot be reached, WebPay fails with a spinner that says "Beginning payment" but never does anything.

This is an example the JS error we get:
E/GeckoConsole(  546): [JavaScript Error: "TypeError: navigator.id is undefined" {file: "https://marketplace.allizom.org/mozpay/media/js/pay-min.js?build=973734e" line: 6}]

We should add a generic timeout to handle this and related errors with a button that says "Try again" or something

Comment 1

[Maureen Hanratty]

Attachment: Error message connecting to Persona

How's this for an error message?

Comment 2

[Kumar McMillan [:kumar]]

yep, that looks good to me

Comment 3

[Kumar McMillan [:kumar]]

Stuart, the bug description says to handle the case when Persona can't be reached but it would be nice to make this a generic timeout/retry handler for anything, such as an unexpected JS error. E.G. You could fire off a setTimeout from the progress spinner -- https://github.com/mozilla/webpay/blob/master/media/js/cli.js -- then clear the timeout in hide progress.

Comment 4

[[e-mail]]

(In reply to Kumar McMillan [:kumar] (on PTO 5/20-5/24) from comment #3)
> Stuart, the bug description says to handle the case when Persona can't be
> reached but it would be nice to make this a generic timeout/retry handler
> for anything, such as an unexpected JS error. E.G. You could fire off a
> setTimeout from the progress spinner --
> https://github.com/mozilla/webpay/blob/master/media/js/cli.js -- then clear
> the timeout in hide progress.

Yep that sounds like a plan.

Comment 5

[[e-mail]]

(In reply to Maureen Hanratty from comment #1)
> Created attachment 747510 [details]
> Error message connecting to Persona
> 
> How's this for an error message?

Looks good, we won't be able to cover the header of the trusted ui but the rest should be possible.

Comment 7

[[e-mail]]

PR: https://github.com/mozilla/webpay/pull/301

Comment 8

[[e-mail]]

https://github.com/mozilla/webpay/commit/c9e1df6cd33a9cd4513a3cc155cbf6294fd8f2e1

Other timeouts will come in other upcoming branches.