870489 - [fireplace] Nonexistent categories should be 404

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Stuart Colville [:muffinresearch]]

STR: 

* Go to a random non-existent category e.g. https://marketplace-altdev.allizom.org/category/anything

What happens:

"No apps in this category, try again later"

What should happen:

This should be a 404 instead.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Same thing for an app.

Comment 2

[Matt Basta [:basta]]

For categories, we can intelligently show an error (`response` is set, even in {% except %} blocks).

For apps, I'm still trying to figure out a clean way of doing this. Suggestions are welcome. The problem is that we don't know that the app doesn't exist until after we've set up the page, fired off at least two requests, and gotten one back as a 404.

Comment 3

[Matt Basta [:basta]]

We can use bug 870020 to track 404'd app detail pages.

Comment 4

[Matt Basta [:basta]]

Davor: Can you wire up your {% except %} magic for categories as well? Just have a nice message that says something like "This category doesn't exist."

I'm not sure if the response code is going to be sufficient (I'm too lazy to look what it is). If not, we can file an API bug to have them return a more expressive code.

Comment 5

[Davor Spasovski [:spasovski]]

The following will address the issue above but I'll file a bug because a missing category currently returns a 400 instead of 404.

https://github.com/mozilla/fireplace/commit/cb61b10

Comment 6

[Iulian Timis]

Issue is still reproducing in https://marketplace-altdev.allizom.org/ on FF26 (Win 7)
Please see screencast http://screencast.com/t/4B81zbiTxKU

Comment 7

[Matt Basta [:basta]]

-altdev is like three months out of date. It works on -dev and in prod:

https://marketplace-dev.allizom.org/category/anything

Comment 8

[Iulian Timis]

Sorry, I thought I had -dev opened.
Verified as fixed in https://marketplace-dev.allizom.org/ on FF26 (Win 7).
Attaching postfix screenshot.
Closing bug.

Comment 9

[Iulian Timis]

Attachment: postfix_nonexistent_category.png