Closed
Bug 870555
Opened 11 years ago
Closed 11 years ago
nsFlexContainerFrame needs a GetSkipSides specialization
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(2 files, 1 obsolete file)
946 bytes,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
1.93 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
nsFlexContainerFrame needs a GetSkipSides specialization to let it correctly ignore borders when being split across pages (or columns in a multicol element). I'm pretty sure we should just crib the implementation from nsBlockFrame. (note: This is a helper-bug for bug 811024. This won't have any visible effects until bug 811024 is fixed.)
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #747617 -
Flags: review?(matspal)
Assignee | ||
Comment 2•11 years ago
|
||
(I do anticipate that we'll have overflow containers for nsFlexContainerFrame, too -- e.g. if a nsFlexContainerFrame has a fixed height that fits on 1 page, and one of its flex items is hugely tall and sticks out far enough to wrap onto the next page, then the chunk of the item on the next page will need its parent to be a continuation of the flex container, and that continuation will be an overflow continuation, and IIUC that's what these IS_TRUE_OVERFLOW_CONTAINER GetSkipSides special-cases are for.)
Comment 3•11 years ago
|
||
Comment on attachment 747617 [details] [diff] [review] fix r=mats
Attachment #747617 -
Flags: review?(matspal) → review+
Comment 4•11 years ago
|
||
Actually, the first if-stmt should have {}
Assignee | ||
Comment 5•11 years ago
|
||
OK -- to avoid making nsFlexContainerFrame and nsBlockFrame diverge on that technicality, I'll post a "part 1" patch to fix that in nsBlockFrame, and then make the existing patch into "part 2" (with the curly braces fixed)
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #747617 -
Attachment is obsolete: true
Attachment #747720 -
Flags: review?(matspal)
Assignee | ||
Comment 7•11 years ago
|
||
...and here's part 2, with the curly braces fixed per comment 4. Carrying forward r=mats.
Attachment #747724 -
Flags: review+
Updated•11 years ago
|
Attachment #747720 -
Flags: review?(matspal) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5aee43eeebe1 https://hg.mozilla.org/integration/mozilla-inbound/rev/494c33bc8dbd
Flags: in-testsuite-
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5aee43eeebe1 https://hg.mozilla.org/mozilla-central/rev/494c33bc8dbd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•