870555 - nsFlexContainerFrame needs a GetSkipSides specialization

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

nsFlexContainerFrame needs a GetSkipSides specialization to let it correctly ignore borders when being split across pages (or columns in a multicol element).

I'm pretty sure we should just crib the implementation from nsBlockFrame.

(note: This is a helper-bug for bug 811024.  This won't have any visible effects until bug 811024 is fixed.)

Comment 1

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

(I do anticipate that we'll have overflow containers for nsFlexContainerFrame, too -- e.g. if a nsFlexContainerFrame has a fixed height that fits on 1 page, and one of its flex items is hugely tall and sticks out far enough to wrap onto the next page, then the chunk of the item on the next page will need its parent to be a continuation of the flex container, and that continuation will be an overflow continuation, and IIUC that's what these IS_TRUE_OVERFLOW_CONTAINER GetSkipSides special-cases are for.)

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 747617 [details] [diff] [review]
fix

r=mats

Comment 4

[Mats Palmgren (inactive)]

Actually, the first if-stmt should have {}

Comment 5

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

OK -- to avoid making nsFlexContainerFrame and nsBlockFrame diverge on that technicality, I'll post a "part 1" patch to fix that in nsBlockFrame, and then make the existing patch into "part 2" (with the curly braces fixed)

Comment 6

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

Attachment: part 1: add curly braces to nsBlockFrame impl

Comment 7

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

Attachment: part 2: Add nsFlexContainerFrame::GetSkipSides specialization [r=mats]

...and here's part 2, with the curly braces fixed per comment 4. Carrying forward r=mats.

Comment 8

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5aee43eeebe1
https://hg.mozilla.org/integration/mozilla-inbound/rev/494c33bc8dbd

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5aee43eeebe1
https://hg.mozilla.org/mozilla-central/rev/494c33bc8dbd