Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Move privacy policy out of app object in API

RESOLVED FIXED in 2013-05-23

Status

Marketplace
API
P4
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: basta, Assigned: ashort)

Tracking

2013-05-23
x86
Mac OS X
Points:
---
Dependency tree / graph

Details

(Reporter)

Description

4 years ago
The privacy policy of apps (especially for games) is almost three times as large as the whole rest of the app object for apps that have a privacy policy. The "Paddle Game" app has a privacy policy that's almost 20kb. Most seem to be around 5kb. For a field that less than a fraction of a percent of users will ever need to access, this takes up an inordinate amount of bandwidth. It also probably contributes to the slowness of the API because it requires an additional DB join to allow it to be localized.
+1. When the new search API comes aboard it would also mean we have to store this in elasticsearch (in each locale) to avoid a database hit, which could bloat our index.
I propose:
/api/v1/apps/app/(int:id)|(string:slug)/privacy_policy/

Which returns something like:
{"body": "..."}

On the backend it's just a simple query by id or slug, localized, and returned.
(Reporter)

Comment 3

4 years ago
I love it, ship it
(Assignee)

Updated

4 years ago
Assignee: nobody → ashort

Comment 4

4 years ago
Please don't use _ in URLs, so far all our API URLs are one word, or if you must, use a -.
Blocks: 875012
(Assignee)

Comment 5

4 years ago
https://github.com/mozilla/zamboni/commit/c34af8147d
https://github.com/mozilla/zamboni/commit/948806e2ee
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Target Milestone: --- → 2013-05-23
You need to log in before you can comment on or make changes to this bug.