Write test for bug 870480: We must notify listeners when a process adds or drops a wake lock, even if the wake lock itself doesn't change state

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Tracking

Trunk
mozilla24
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I'd like to write an automated test for bug 870480, but it's kind of tricky, because right now the information we want to test is exposed only to C++, but the testcase needs to involve HTML.

Anyway, I'll figure something out.
(Assignee)

Updated

6 years ago
Assignee: nobody → justin.lebar+bug
Created attachment 755599 [details] [diff] [review]
Patch, v1

Well, that was easier than I thought it would be.
Attachment #755599 - Flags: review?(21)
Comment on attachment 755599 [details] [diff] [review]
Patch, v1

Review of attachment 755599 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I'm not a fan of wl1 and wl2 for naming variables but I guess that does not really matter. I'm not even sure the variables are useful here?
Attachment #755599 - Flags: review?(21) → review+
You're right; we don't need the variables.

Thanks for the review!

https://hg.mozilla.org/projects/birch/rev/73ef9ee69965
https://hg.mozilla.org/mozilla-central/rev/73ef9ee69965
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.