If HFP connection cannot be established, try HSP

RESOLVED FIXED in 1.0.1 Cert2 (21may)

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: echou, Assigned: arthurcc)

Tracking

unspecified
1.0.1 Cert2 (21may)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.1 fixed)

Details

(Whiteboard: [status:justlanditplease][target:05/17])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Currently in Settings/Bluetooth, we do

  defaultAdapter.connect(device.address, 0x111E);

to connect with remote Bluetooth headsets. The magic number 0x111E is actually the UUID of Handsfree profile (HFP). This works well when the target Bluetooth headset supports HFP. However, there is another Bluetooth profile used in some headset models called Headset profile (HSP, UUID 0x1108). With current implementation, we have no chance to establish a HSP connection with those HSP-only devices. Moreover, to do Bluetooth HSP certification test, we have to modify 0x111E to 0x1108 manually.

We should check do something like "Try HFP first, if an error is returned, check if the reason of the failure is 'the remote device doesn't support HFP'. If it is, then try HSP".
(Reporter)

Comment 1

6 years ago
Nominate as tef+ since we want Bluetooth HSP certification could run smoothly.
Blocks: 861047
blocking-b2g: --- → tef?
Assignee: nobody → arthur.chen

Updated

6 years ago
blocking-b2g: tef? → tef+

Comment 2

5 years ago
(In reply to Eric Chou [:ericchou] [:echou] from comment #1)
> Nominate as tef+ since we want Bluetooth HSP certification could run
> smoothly.

Does this actually block certification though?
blocking-b2g: tef+ → tef?
(Reporter)

Comment 3

5 years ago
(In reply to Alex Keybl [:akeybl] from comment #2)
> (In reply to Eric Chou [:ericchou] [:echou] from comment #1)
> > Nominate as tef+ since we want Bluetooth HSP certification could run
> > smoothly.
> 
> Does this actually block certification though?

Yes it does. Like I said, we have no way for partners to test HSP unless they modify settings/bluetooth.js on their own.
(Reporter)

Updated

5 years ago
Depends on: 850157
per comment 3, let's stick to tef+
blocking-b2g: tef? → tef+
Whiteboard: [status: patch needed]
Target Milestone: --- → 1.0.1 Cert2 (28may)
Created attachment 748745 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9718

Evelyn, Alive, I am waiting for Eric checking this patch. Because this issue is urgent, I would like you take a look at the patch first. It's fine to give the final review once Eric confirms that this patch does solve the problem. Thanks!
Attachment #748745 - Flags: review?(ehung)
Attachment #748745 - Flags: review?(alive)
Comment on attachment 748745 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9718

r=me for system app part.
Attachment #748745 - Flags: review?(alive) → review+
Whiteboard: [status: patch needed] → [target:05/17]

Comment 7

5 years ago
Comment on attachment 748745 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9718

r=me, I left one comment on PR. Thanks for your work!
Attachment #748745 - Flags: review?(ehung) → review+
Looks like things are in good shape here. Can this be landed and resolved?
I've re-tested based on Comment 7 pull request, it's good to go! Please just land it.
Whiteboard: [target:05/17] → [status:justlanditplease][target:05/17]
Thank you for doing the review and test!

master: https://github.com/mozilla-b2g/gaia/commit/25253ebe685b3c112bb52b8f0af7c832eed9ea79
v1-train: https://github.com/mozilla-b2g/gaia/commit/23cec618ba1ad9f39da1fc5dfa2a4df2b2d5f933
v1.0.1: https://github.com/mozilla-b2g/gaia/commit/1a9dfa4599d3ac42d0e21a564d734a070a17f89a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g18: --- → fixed
status-b2g18-v1.0.1: --- → fixed
Resolution: --- → FIXED
No longer depends on: 850157

Comment 11

5 years ago
Can you please provide steps to verify this fix - as we can perform blackbox testing from the UI?
You need to log in before you can comment on or make changes to this bug.