870800 - Advanced Search link in review queue pages doesn't do anything

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Clicking on the Advanced Search link in a review queue page should toggle a form with advanced search options. It looks like it broke in a recent push, and it currently doesn't do anything. I also didn't notice any errors in the Error Console while testing it.

Comment 1

[Kevin Ngo [:ngoke]]

On mobile? And on which queue? Works for me on desktop Firefox.

Comment 2

[Andreas Wagner [:TheOne] [use NI]]

https://github.com/mozilla/zamboni/pull/760

Comment 3

[Andreas Wagner [:TheOne] [use NI]]

(In reply to Kevin Ngo [:ngoke] from comment #1)
> On mobile? And on which queue? Works for me on desktop Firefox.

on addons (not marketplace)?

I can reproduce on desktop. Which queue is irrelevant. See my pull request.

Comment 4

[Kevin Ngo [:ngoke]]

Thanks, Andreas.

https://github.com/mozilla/zamboni/commit/e814d9aeb0ad1ccc654ec35d438f390151d288c4

Comment 5

[Andreas Wagner [:TheOne] [use NI]]

Thank you Kevin for reviewing this. Sorry for my previous comment, I was a bit upset because it took me more than four hours to get zamboni running that night (and less than one hour for this patch). That's also why I haven't taken this bug immediately, I first needed to get a running local instance to test on.