Closed
Bug 870848
Opened 11 years ago
Closed 11 years ago
Integrate SSO into Popcorn Maker
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sedge, Assigned: mjschranz)
References
Details
(Whiteboard: u=dev c=popcorn p=1 s=2013w20)
Attachments
(1 file)
Popcorn Maker needs to implement the Webmaker SSO, and the standard server-side session format that SSO is built to allow. From the email: * Implement Persona authentication exactly as you normally would, using the .watch() API. MIU has a pretty standard implementation of this: https://github.com/jbuck/miu/blob/master/views/index.html and https://github.com/jbuck/miu/blob/master/public/javascripts/persona.js * Replace the script "https://login.persona.org/include.js" with "http://personasso.s3-website-us-east-1.amazonaws.com/include.js". This is not the final location, it's just a place that happens to work well enough for me. a * Replace the calls to navigator.id with navigator.idSSO. That's it! You can see how easy this conversion to SSO is with https://github.com/jbuck/miu/compare/sso
Assignee | ||
Comment 1•11 years ago
|
||
Going to take this for now so we have an owner.
Assignee: nobody → schranz.m
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #750502 -
Flags: review?(jon)
Comment 3•11 years ago
|
||
Comment on attachment 750502 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/10 Needs a rebase on master to fix lint errors, and two small URL-related nits to fix. r+
Attachment #750502 -
Flags: review?(jon) → review+
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/cf037461983350b56f437274722800c24c91cc66 Bug 870848 - SSO integration into Popcorn Maker
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•