Closed
Bug 870892
Opened 11 years ago
Closed 11 years ago
[MMS] [UX] Thread list. The attachment icon is croppped
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:leo+, b2g18 fixed)
People
(Reporter: vicky, Assigned: greg)
References
Details
(Keywords: regression)
Attachments
(3 files)
26.74 KB,
image/png
|
Details | |
22.23 KB,
image/png
|
Details | |
46 bytes,
patch
|
gnarf
:
review+
julienw
:
review+
bajaj
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
The attachment icon is cropped in the threads list view-
Updated•11 years ago
|
blocking-b2g: --- → tef?
Comment 1•11 years ago
|
||
tef? is to block for 1.0.1 releases and MMS is not part of that release, I am removing the nomination, not sure what flag/version you want to use here.
blocking-b2g: tef? → ---
Comment 2•11 years ago
|
||
Can you confirm this has been fixed or needs additional attention?
Updated•11 years ago
|
Flags: needinfo?
Looks like this was fixed! Tested in nightly as well as device
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?
Resolution: --- → WORKSFORME
Comment 4•11 years ago
|
||
Some times the icon is cropped, sometimes you can see a repetition in the right side...
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
:borjasalguero if it is an inconsistant issue can you please provide steps to reproduce. I cannot reproduce and therefor cannot fix.
Flags: needinfo?(fbsc)
Comment 6•11 years ago
|
||
Greg, I can only reproduce it on the device. Sometimes (depending of the time text after - the time-) you will see it cropped or with a new 'attachment' icon appearing in the right side (some pixels).
Flags: needinfo?(fbsc)
:gnarf was able to reproduce and he found that this is caused by unread messages with a long enough timestamp. I'll add screenshots.
Attachment #755487 -
Flags: review?(gnarf37)
Attachment #755487 -
Flags: review?(felash)
Attachment #755487 -
Flags: review?(fbsc)
Comment 10•11 years ago
|
||
Comment on attachment 755487 [details] [diff] [review]
Pull Request
r=me
the new patch looks good, thanks !
don't forget to update the commit log with a more meaningful comment !
Attachment #755487 -
Flags: review?(felash) → review+
Comment 11•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment #755487 -
Flags: review?(gnarf37)
Attachment #755487 -
Flags: review?(fbsc)
Attachment #755487 -
Flags: review+
Comment 12•11 years ago
|
||
Comment on attachment 755487 [details] [diff] [review]
Pull Request
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 862311
User impact if declined: Broken Images for Attachment
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low, css/html changes mostly, removes a workaround in js no longer needed for mms with new css
String or UUID changes made by this patch: none
This fixes a bug in the attachment icon/thread list rendering we just uplifted.
Attachment #755487 -
Flags: approval-mozilla-b2g18?
Updated•11 years ago
|
blocking-b2g: --- → leo?
Updated•11 years ago
|
Attachment #755487 -
Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Updated•11 years ago
|
blocking-b2g: leo? → leo+
Keywords: regression
Updated•11 years ago
|
status-b2g18:
--- → affected
You need to log in
before you can comment on or make changes to this bug.
Description
•