870989 - Menu panel has no right border.

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Demonstration of problem

See screenshot.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I just saw this on Windows too.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Mike, this fixes the problem for me on Windows. Can you verify that it is good for you on Linux?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I tested this on Ubuntu via DOMi and it fixes the bug.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 751968 [details] [diff] [review]
Patch

Review of attachment 751968 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ +52,5 @@
>    overflow: visible;
>  }
>  
>  #PanelUI-popup > .panel-arrowcontainer > .panel-arrowcontent {
>    padding: 0;

MattN told me once we should try to strive for alphabetical ordering within our CSS rules. I know I've been guilty myself of not doing this, but thought I'd suggest swapping these two lines.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

And yes, I can confirm this fixes the problem on Ubuntu.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/ux/rev/6d2afa9eaf9a

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/6d2afa9eaf9a