Closed Bug 870989 Opened 7 years ago Closed 6 years ago

Menu panel has no right border.

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:M7])

Attachments

(2 files)

No longer blocks: 770135
Whiteboard: [Australis:M7]
I just saw this on Windows too.
OS: Linux → All
Hardware: x86 → All
Attached patch PatchSplinter Review
Mike, this fixes the problem for me on Windows. Can you verify that it is good for you on Linux?
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #751968 - Flags: review?(mconley)
I tested this on Ubuntu via DOMi and it fixes the bug.
Comment on attachment 751968 [details] [diff] [review]
Patch

Review of attachment 751968 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ +52,5 @@
>    overflow: visible;
>  }
>  
>  #PanelUI-popup > .panel-arrowcontainer > .panel-arrowcontent {
>    padding: 0;

MattN told me once we should try to strive for alphabetical ordering within our CSS rules. I know I've been guilty myself of not doing this, but thought I'd suggest swapping these two lines.
Attachment #751968 - Flags: review?(mconley) → review+
And yes, I can confirm this fixes the problem on Ubuntu.
https://hg.mozilla.org/projects/ux/rev/6d2afa9eaf9a
Whiteboard: [Australis:M7] → [Australis:M7][fixed in ux]
https://hg.mozilla.org/mozilla-central/rev/6d2afa9eaf9a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed in ux] → [Australis:M7]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.