Closed
Bug 871022
Opened 11 years ago
Closed 11 years ago
Remove unused GeckoApp.StartupMode code
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox22 wontfix, firefox23 fixed)
RESOLVED
FIXED
Firefox 24
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(1 file)
|
4.24 KB,
patch
|
lucasr
:
review+
bnicholson
:
feedback+
|
Details | Diff | Splinter Review |
GeckoApp's StartupMode enum and getStartupMode() method are no longer used.
Attachment #748241 -
Flags: review?(lucasr.at.mozilla)
|
||
Updated•11 years ago
|
Attachment #748241 -
Flags: feedback?(bnicholson)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 748241 [details] [diff] [review] remove-unused-StartupMode.patch Review of attachment 748241 [details] [diff] [review]: ----------------------------------------------------------------- I'm fine with removing it but I do wonder if we'll end up needing it again once we implement our first-run experience. We can just restore this code if needed I guess.
Attachment #748241 -
Flags: review?(lucasr.at.mozilla) → review+
|
||
Comment 2•11 years ago
|
||
Comment on attachment 748241 [details] [diff] [review] remove-unused-StartupMode.patch LGTM
Attachment #748241 -
Flags: feedback?(bnicholson) → feedback+
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/73ee08fc5adb
status-firefox22:
--- → wontfix
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/73ee08fc5adb
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•