871066 - "Error: ReferenceError: CommandUtils is not defined" when opening devtools with Simulator 3.0 installed

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P1)

Description

[Heather Arthur [:harth]]

STR:
Install Firefox OS Simulator 3.0 (https://addons.mozilla.org/en-US/firefox/addon/firefox-os-simulator/). Open the devtools window.

expected:
Devtools window opens with one of the tools selected.

actual: 
Devtools window opens with a blank panel, buttons are missing, and this error is in the console:

Error: ReferenceError: CommandUtils is not defined
Source File: resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js
Line: 322

Comment 1

[Heather Arthur [:harth]]

From bisecting, likely caused by bug 839862

Comment 2

[Heather Arthur [:harth]]

Joe, do you know what could be causing this? People with the Simulator installed are likely to be using the devtools, so I think it's a serious bug.


This only occurs when you launch the devtools from the browser, launching them from the Simulator itself seems to work fine.

Comment 3

[Joe Walker [:jwalker]]

I"m having trouble reproducing this. Can anyone get me a stack trace?

Comment 4

[Heather Arthur [:harth]]

Ah, the first time you open the devtools, this error occurs:

Error: Error: Error: Redefining module: gcli/index
Source File: resource://gre/modules/devtools/Require.jsm
Line: 50

Then the CommandUtils error.

Comment 5

[Joe Walker [:jwalker]]

I think I've got a fix. It's a bit ugly though. Will post patch

Comment 6

[Joe Walker [:jwalker]]

Attachment: v1

Comment 7

[Joe Walker [:jwalker]]

Comment on attachment 748881 [details] [diff] [review]
v1

I think I might be able to do this better with out all the renames. Working on it ...

Comment 8

[Joe Walker [:jwalker]]

Attachment: v2

Much simpler fix, and wfm.

Comment 9

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=2669e09ec568

Comment 10

[Heather Arthur [:harth]]

Comment on attachment 748888 [details] [diff] [review]
v2

Cheers, this fixes it for me.

Comment 11

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=3e3eacd702db
https://hg.mozilla.org/integration/fx-team/rev/3e3eacd702db

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

This just missed the Aurora uplift, so it will have to be uplifted manually.

Comment 13

[Joe Walker [:jwalker]]

Aurora try: https://tbpl.mozilla.org/?tree=Try&rev=5ef1dc23692c

Comment 14

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/3e3eacd702db

Comment 15

[Joe Walker [:jwalker]]

Comment on attachment 748888 [details] [diff] [review]
v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 839862
User impact if declined: Developer Tools is broken with Simulator 3.0 installed
Testing completed (on m-c, etc.): Baked on m-c for over a week
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch: None.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b31dd759578a

Comment 17

[Simona Badau, Desktop QA]

I can't reproduce the initial issue on a 2013-05-10 Nightly on Mac OS X 10.8.
These are the steps that I use:
1. Launch Firefox.
2. Install Firefox OS Simulator 3.0 add-on.
3. Open the Developer tools window (Tools Menu-> Web Developer -> Toggle Tools).

Does anyone have any idea? Am I missing something?

Comment 18

[Joe Walker [:jwalker]]

This is a clash-of-versions problem. I don't think it's worth the effort to repro the original problem, personally.

Comment 19

[Simona Badau, Desktop QA]

Based on Comment 18, I'm removing the verifyme keyword.