Closed
Bug 871090
Opened 11 years ago
Closed 3 years ago
StrictMode violation in GeckoPreferences
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: rnewman, Unassigned)
References
Details
setupTitlebarPref is the first to access BrowserToolbar's prefs file, so it incurs a disk read. StrictMode policy violation; ~duration=36 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=31 violation=2 at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1198) at android.app.SharedPreferencesImpl.awaitLoadedLocked(SharedPreferencesImpl.java:184) at android.app.SharedPreferencesImpl.getBoolean(SharedPreferencesImpl.java:241) at org.mozilla.gecko.GeckoPreferences.setupTitlebarPref(GeckoPreferences.java:604) at org.mozilla.gecko.GeckoPreferences.setupPreferences(GeckoPreferences.java:212) at org.mozilla.gecko.GeckoPreferences.setupPreferences(GeckoPreferences.java:194) at org.mozilla.gecko.GeckoPreferences.setupPreferences(GeckoPreferences.java:186) at org.mozilla.gecko.GeckoPreferenceFragment.onCreate(GeckoPreferenceFragment.java:34) It should probably do what BrowserToolbar does. That is, instead of: private void setupTitlebarPref(final ListPreference pref) { final SharedPreferences settings = getSharedPreferences(BrowserToolbar.PREFS_NAME, 0); do (new UiAsyncTask<Void, Void, Void>(ThreadUtils.getBackgroundHandler()) { @Override public synchronized Void doInBackground(Void... params) { SharedPreferences settings = mActivity.getSharedPreferences(PREFS_NAME, 0);
Comment 1•11 years ago
|
||
Most of this was removed in bug 868845.
Updated•10 years ago
|
Blocks: strictmode
Comment 2•3 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•