Closed
Bug 871181
Opened 12 years ago
Closed 12 years ago
Fix rooting hazards in ObjectWrapperChild.cpp
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file, 1 obsolete file)
|
8.73 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #748467 -
Flags: review?(tschneidereit)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 748467 [details] [diff] [review]
Patch (v1)
Review of attachment 748467 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/ipc/ObjectWrapperChild.cpp
@@ +303,2 @@
> return false;
>
Can you fix the superfluous whitespace in this file while you're in there?
@@ +342,5 @@
> AutoContextPusher acp(cx);
> AutoCheckOperation aco(this, status);
>
> + if (!jsid_from_nsString(cx, id, interned_id.address()) ||
> + !jsval_from_JSVariant(cx, v, val.address()))
Pre-existing, but please add braces here.
Attachment #748467 -
Flags: review?(tschneidereit) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Comments addressed.
Attachment #748467 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•