871189 - Remove Document classinfo

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 748479 [details] [diff] [review]
Patch

Please don't land this until after the Aurora branchpoint so if we have to we can flip the switch on HTMLDocument back on 23.

You can remove DOCUMENT_SCRIPTABLE_FLAGS.

You can also remove sDocumentURIObject_id.

And you can remove the bits dealing with documentURIObject in XrayWrapper.cpp.

r=me with all that.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 748479 [details] [diff] [review]
Patch

Review of attachment 748479 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDOMClassInfo.h
@@ +595,3 @@
>  // HTMLDocument helper
>  
> +class nsHTMLDocumentSH : public nsNodeSH

I'd rather this didn't inherit nsNodeSH, if possible.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Er, wait.  Why didn't nsHTMLDocumentSH go away in this patch?

Comment 4

[David Zbarsky (:dzbarsky)]

(In reply to Boris Zbarsky (:bz) from comment #3)
> Er, wait.  Why didn't nsHTMLDocumentSH go away in this patch?

nsHTMLDocumentSH::TryResolveAll is called from nsHTMLDocument, and that calls all the static functions that I didn't remove.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Gah.  We need to fix .all to not be sucky like that.

But given that, do you actually need to inherit from nsNodeSH?

Comment 6

[David Zbarsky (:dzbarsky)]

(In reply to Boris Zbarsky (:bz) from comment #5)
> Gah.  We need to fix .all to not be sucky like that.
> 
> But given that, do you actually need to inherit from nsNodeSH?

No, I just changed how we access the static stuff in nsDOMClassInfo.
https://hg.mozilla.org/integration/mozilla-inbound/rev/eaaa2d2ce8eb

Comment 7

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a83bc79f7c57

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eaaa2d2ce8eb
https://hg.mozilla.org/mozilla-central/rev/a83bc79f7c57