Remove Document classinfo

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 748479 [details] [diff] [review]
Patch
Attachment #748479 - Flags: review?(bzbarsky)
Comment on attachment 748479 [details] [diff] [review]
Patch

Please don't land this until after the Aurora branchpoint so if we have to we can flip the switch on HTMLDocument back on 23.

You can remove DOCUMENT_SCRIPTABLE_FLAGS.

You can also remove sDocumentURIObject_id.

And you can remove the bits dealing with documentURIObject in XrayWrapper.cpp.

r=me with all that.
Attachment #748479 - Flags: review?(bzbarsky) → review+
Comment on attachment 748479 [details] [diff] [review]
Patch

Review of attachment 748479 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDOMClassInfo.h
@@ +595,3 @@
>  // HTMLDocument helper
>  
> +class nsHTMLDocumentSH : public nsNodeSH

I'd rather this didn't inherit nsNodeSH, if possible.
Er, wait.  Why didn't nsHTMLDocumentSH go away in this patch?
(Assignee)

Comment 4

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #3)
> Er, wait.  Why didn't nsHTMLDocumentSH go away in this patch?

nsHTMLDocumentSH::TryResolveAll is called from nsHTMLDocument, and that calls all the static functions that I didn't remove.
Gah.  We need to fix .all to not be sucky like that.

But given that, do you actually need to inherit from nsNodeSH?
(Assignee)

Comment 6

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #5)
> Gah.  We need to fix .all to not be sucky like that.
> 
> But given that, do you actually need to inherit from nsNodeSH?

No, I just changed how we access the static stuff in nsDOMClassInfo.
https://hg.mozilla.org/integration/mozilla-inbound/rev/eaaa2d2ce8eb
https://hg.mozilla.org/mozilla-central/rev/eaaa2d2ce8eb
https://hg.mozilla.org/mozilla-central/rev/a83bc79f7c57
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.