8712 - [BLOCKER] nsCOMPtr being used incorrectly in editor/base/InsertTextTxn.cpp

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[tague]

InsertTextTxn::Merge is using nsComPtr incorrectly.  This causes a crash when I
try to mix my new Input Method transactions with InsertTextTxn's.

The problem is in line 125,
nsCOMPtr<EditAggregateTxn> otherTxn( do_QueryInterface(aTransaction) );

This returns a pointer to an nsITransaction interface, not an EditAggregateTxn
pointer. The subsequent call to EditAggregateTxn::GetName crashes for the Input
Method transactions because they implement nsITransaction (and return an
nsITransaction interface in otherTxn) but they don't implement EditAggregateTxn.
Since all of the non-IME text is wrapped up in EditAggregateTxn's anyway, the
problem is masked in ASCII typing.

Comment 1

[buster]

fixed.  nsCOMPtr is no longer used for concrete classes.  Tague, please verify
because QA won't be able to.

Comment 2

[tague]

it was very fixed in my pull today.  thanks.  verifying since this is a code
verified fix.