871244 - Shortcut icons should update when results change

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

The Shortcut icons that come bundled with the phone are never updated, even if the apps for the folders themselves change.

Example, the shortcut for Sports shows ESPN, Yahoo, NBC. Clicking on it from Spain will show localized apps AS, Marca, El Pais. The shortcut icons now are misrepresenting the results.

So, we need a way to update icons when a user opens a smart folder and sees different apps in it.

* This is a subset of ticket #871243 which is a more robust solution.
* This PR is meant for v1.0.1. Once it's approved, we'll advance with ticket #871243.

Comment 1

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

The patch updates the smart folder's icon with the latest apps from the API.

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 748519 [details]
Patch - redirect to github PR

some minor change on Github, please review a few comments but the patch is ok for me, great work!

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

reviewed and fixed/answered all feedback!

Comment 4

[Cristian Rodriguez (:crdlc)]

perfect r+ go ahead Evyatar, thanks

Comment 5

[Evyatar 'Tron' Amitay (everything.me)]

merged

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Since this fix is needed for v1.0.1, marking tef+ go ahead with uplift.

Comment 7

[Evyatar 'Tron' Amitay (everything.me)]

merged

09299399500b50de72cdd3b4365fc6455bbbb145

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

$ git branch --contains 09299399500b50de72cdd3b4365fc6455bbbb145
  v1.0.1

Is this applicable to v1-train or master?

Comment 9

[Evyatar 'Tron' Amitay (everything.me)]

Hi John,

This was already uplifted to v1.0.1 (comment #7)
https://github.com/mozilla-b2g/gaia/commit/09299399500b50de72cdd3b4365fc6455bbbb145

it's also on master
https://github.com/mozilla-b2g/gaia/commit/9446d22fce99e80422a10e5a095c6f340404c845


I'm not sure it's on v1-train, I don't see it in the branch --contains command.
It could've been missed on v1-train since it was rushed (comment #6). should I merge the commit from master into v1-train?

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Yes, looks like it's on v1.0.1 and master but not v1-train.  The master commit doesn't apply to v1-train, but the v1.0.1 commit does.  Is it valid to apply the v1.0.1 commit to v1-train?

Comment 11

[Evyatar 'Tron' Amitay (everything.me)]

It looks the same in both master and v1.0.1, can't for the life of me understand why one yields conflicts but the other doesn't.

anyway I uplifted the master commit properly, there were 2 minor conflicts that were obvious.

v1-train merge commit
0f2d8fe3746fb48b0d4d1569eb9c3711022948fa

https://github.com/mozilla-b2g/gaia/commit/0f2d8fe3746fb48b0d4d1569eb9c3711022948fa

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

marking branch flag as fixed on v1-train per comment 11

Comment 13

[Jeni]

Can you please provide steps to verify this fix - as we can perform blackbox testing from the UI?

Comment 14

[Ran Ben Aharon [:ranbena] EverythingMe]

Steps to verify:
1. Make sure device is in default English language.
2. Load E.me. Notice the "News" shortcut has "Yahoo" as the foremost icon.
3. Click on the "News" shortcut and wait for results to appear.
4. Notice the leftmost icon (under the separator) is "Google News".
5. Click the top left "X" to return to E.me home.
6. If the patch works correctly, the "News" foremost icon has changed from "Yahoo" to "Google News".

* The icons detailed will defer within different worldwide locations and system languages.

Comment 15

[Jeni]

Issue still repros on 

Inari Build ID: 20130624070215
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
Gaia: 93241eb6c5d6c110710fad8da3ccd4423312b0c9
Platform Version: 18.0

When user follows steps from Comment 14 the foremost icon is not changed from 'Yahoo' to 'Google' instead it stays 'Yahoo'

Comment 16

[Ran Ben Aharon [:ranbena] EverythingMe]

Jeni, what location was this tested in? And what is the system language?

Comment 17

[Jeni]

(In reply to Ran Ben Aharon (Everything.me) from comment #16)
> Jeni, what location was this tested in? And what is the system language?

This was tested in English and Spanish.  The left most icon is yahoo and stays yahoo when closing out and going back in.  Unable to change the order unless you know of a way that makes that possible.

Comment 18

[Ran Ben Aharon [:ranbena] EverythingMe]

(In reply to Jeni from comment #17)
> This was tested in English and Spanish.  The left most icon is yahoo and
> stays yahoo when closing out and going back in.  Unable to change the order
> unless you know of a way that makes that possible.

Order of what?
And what is your geographical location?

Comment 19

[Jeni]

(In reply to Ran Ben Aharon (Everything.me) from comment #18)
> (In reply to Jeni from comment #17)
> > This was tested in English and Spanish.  The left most icon is yahoo and
> > stays yahoo when closing out and going back in.  Unable to change the order
> > unless you know of a way that makes that possible.
> 
> Order of what?
> And what is your geographical location?

I am in the USA, in Washington State and comment 14 says 6. If the patch works correctly, the "News" foremost icon has changed from "Yahoo" to "Google News".
it does not do that for me

Comment 20

[Ran Ben Aharon [:ranbena] EverythingMe]

That's due to your location being the US and Yahoo being the first app in News results for US users.

Here's a few that will work in your location:
1. First icon in Weather is "TWC" (The Weather Channel - blue background), click on it, first result displayed is not "TWC", return to E.me home - the icon has changed.
2. First icon in Funny is a "FunnyTube" (green smile), click on it, first result displayed is not "FunnyTube" (may be CheezeBurger), return to E.me home - the icon has changed.
3. First icon in Movies is a "Flixster" (popcorn icon), click on it, first result displayed is not "Flixster" (may be IMDB), return to E.me home - the icon has changed.

The big idea is that the shortcut icon reflects the first 3 apps in the folder.

* It's hard to anticipate the exact outcome because of various parameters influencing the results and ever-changing and ever-growing E.me app index.

Comment 21

[Jeni]

(In reply to Ran Ben Aharon (Everything.me) from comment #20)
> That's due to your location being the US and Yahoo being the first app in
> News results for US users.
> 
> Here's a few that will work in your location:
> 1. First icon in Weather is "TWC" (The Weather Channel - blue background),
> click on it, first result displayed is not "TWC", return to E.me home - the
> icon has changed.
> 2. First icon in Funny is a "FunnyTube" (green smile), click on it, first
> result displayed is not "FunnyTube" (may be CheezeBurger), return to E.me
> home - the icon has changed.
> 3. First icon in Movies is a "Flixster" (popcorn icon), click on it, first
> result displayed is not "Flixster" (may be IMDB), return to E.me home - the
> icon has changed.
> 
> The big idea is that the shortcut icon reflects the first 3 apps in the
> folder.
> 
> * It's hard to anticipate the exact outcome because of various parameters
> influencing the results and ever-changing and ever-growing E.me app index.

Based on the steps you listed the big no longer repros on Leo Device.  Thank you for clarification.

Comment 22

[Ran Ben Aharon [:ranbena] EverythingMe]

Great!