Closed
Bug 871245
Opened 11 years ago
Closed 11 years ago
Don't hardcode "Firefox" in gclicommands.properties
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
2.58 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
listenManual=Firefox can allow remote debugging over a TCP/IP connection. For security reasons this is turned off by default, but can be enabled using this command. All hardcoded instances of Firefox were removed in recent bugs.
Assignee | ||
Updated•11 years ago
|
Summary: Don't harcode "Firefox" in gclicommands.properties → Don't hardcode "Firefox" in gclicommands.properties
Assignee | ||
Comment 1•11 years ago
|
||
This patch should work, unfortunately I can't test it locally since the current nightly doesn't have the "listen" command yet. Asking review to :dcamp based on the commit comment (even if I don't see him in bug 839862's patch review)
Attachment #748515 -
Flags: review?(dcamp)
Updated•11 years ago
|
Attachment #748515 -
Flags: review?(dcamp) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/75a229522767
Assignee: nobody → francesco.lodolo
Keywords: checkin-needed
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75a229522767
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•