Closed
Bug 871255
Opened 11 years ago
Closed 11 years ago
Warning 'TypeError: redeclaration of var calInstanceOf' in calUtils.js
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
3.0
People
(Reporter: ssitter, Assigned: Fallen)
Details
Attachments
(1 file, 1 obsolete file)
1.12 KB,
patch
|
mschroeder
:
review+
|
Details | Diff | Splinter Review |
> Warning: TypeError: redeclaration of var calInstanceOf > Source file: chrome://calendar/content/calUtils.js > Line: 438, Column: 9 > Source code: > function calInstanceOf(aObject, aInterface) { Function calInstanceOf() is declared twice in calUtils.js: http://mxr.mozilla.org/comm-central/ident?i=calInstanceOf&filter=calUtils.js
Assignee | ||
Comment 1•11 years ago
|
||
One was added in the backout here: https://hg.mozilla.org/comm-central/rev/c1d9ed13f285 And the other is from deprecation. I'm going to merge them together to deprecate now, but with the old implementation. Mohit can then take care of the review comments in bug 788004.
Assignee | ||
Comment 2•11 years ago
|
||
Reporter | ||
Comment 3•11 years ago
|
||
Maybe the obsolete implementation should be removed completely? The message "Use of calInstanceOf() is deprecated and will be removed with the next release. Use cal.wrapInstance() instead." is incorrect because there exists no function wrapInstance() in the calendar code.
Assignee | ||
Comment 4•11 years ago
|
||
I can change the message slightly, but the minimum I want to see is the old function with a deprecation message, so its clear that the function will be removed in a future release. It really depends on if Mohit has time for the other bug.
Reporter | ||
Comment 5•11 years ago
|
||
Comment on attachment 748680 [details] [diff] [review] Fix - v1 r- because the warning is incorrect. Bug 788004 is being worked on, will it take care of this problem?
Attachment #748680 -
Flags: review?(ssitter) → review-
Assignee | ||
Comment 6•11 years ago
|
||
The patch in bug 788004 doesn't contain the fix to actually remove the duplicate function. I'd like to push both bugs as soon as the tree opens again and with bug 788004 applied, the warning message is correct again.
Attachment #748680 -
Attachment is obsolete: true
Attachment #785781 -
Flags: review?(ssitter)
Attachment #785781 -
Flags: approval-calendar-aurora+
Comment 7•11 years ago
|
||
Comment on attachment 785781 [details] [diff] [review] Fix - v2 Taking over review, r+ as this function is not used in Calendar code anymore and the other version has a warning message. Approval for aurora is not needed anymore as the release went without this fix.
Attachment #785781 -
Flags: review?(ssitter)
Attachment #785781 -
Flags: review+
Attachment #785781 -
Flags: approval-calendar-aurora+
Assignee | ||
Comment 8•11 years ago
|
||
Pushed to comm-central changeset 76f711a54fd3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.9
Updated•11 years ago
|
OS: Windows 7 → All
Hardware: x86_64 → All
Target Milestone: 2.9 → 3.0
You need to log in
before you can comment on or make changes to this bug.
Description
•