Closed Bug 871258 Opened 6 years ago Closed 6 years ago

Missing privacy icon for all-day events in week-view

Categories

(Calendar :: Calendar Views, defect)

Lightning 1.9.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bv1578, Assigned: bv1578)

Details

Attachments

(1 file)

Steps to reproduce:

1. in week-view create an all-day event;
2. set the privacy status to "Private Event" or to "Show Time and Date only". 

Result:
the event box doesn't show the icon related to privacy status (the icon related to the reminder is correctly showed).
Attached patch patch - v1Splinter Review
I had to add the icon directly in the "calendar-editable-item" binding.
In this way the icon appears also in the today-pane so I added a rule in order to delete it (unless we want to keep it for all-day events in the today-pane too).
Attachment #748526 - Flags: review?(philipp)
Comment on attachment 748526 [details] [diff] [review]
patch - v1

Personally I think we should not show it in the today pane as you did in the patch, as the goal for the today pane is to give an overview of what is upcoming. The privacy status is not so important there.

r=philipp
Attachment #748526 - Flags: review?(philipp) → review+
(In reply to Philipp Kewisch [:Fallen] from comment #2)
> ... The privacy status is not so important there.

Ok.

Pushed on comm-central:
https://hg.mozilla.org/comm-central/rev/385e5d45032a

-> Fixed
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.6
You need to log in before you can comment on or make changes to this bug.