871264 - Remove the aPresContext and aFrame parameters from ThemeDrawsFocusForWidget

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Jonathan Watt [:jwatt]]

As noted by roc in bug 862693 comment 11, we should remove the aPresContext and aFrame parameters from ThemeDrawsFocusForWidget.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Heck, might as well add MOZ_OVERRIDE while I'm touching these lines.

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 748533 [details] [diff] [review]
patch

I don't normally review /gfx or /widget code, but given the trivial nature of this bug and given that roc already rubber-stamped the idea by suggesting it, I'm happy to do a sanity-check review. So, r=me

Technically, I think this needs sr, since it's a change to an interface.

I bet roc would grant speedy sr.  I'll take the liberty of sr?'ing him, to keep the process moving.

Comment 4

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af5273034fdf

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Backed out, since it didn't compile:
https://hg.mozilla.org/integration/mozilla-inbound/rev/abc9d00d1025

../../../layout/forms/nsRangeFrame.cpp: In member function 'virtual void nsRangeFrame::BuildDisplayList(nsDisplayListBuilder*, const nsRect&, const nsDisplayListSet&)':
../../../layout/forms/nsRangeFrame.cpp:248:71: error: no matching function for call to 'nsITheme::ThemeDrawsFocusForWidget(nsPresContext*&, nsRangeFrame* const, const uint8_t&)'
../../dist/include/nsITheme.h:156:16: note: candidate is: virtual bool nsITheme::ThemeDrawsFocusForWidget(uint8_t)
make[6]: *** [nsRangeFrame.o] Error 1

Comment 6

[Jonathan Watt [:jwatt]]

Oops - I managed to conflict with a different patch I pushed a day earlier. Thanks for backing out. Re-pushed as:

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e5f9688566c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e5f9688566c