Closed Bug 871264 Opened 7 years ago Closed 7 years ago
Remove the a
Pres Context and a Frame parameters from Theme Draws Focus For Widget
As noted by roc in bug 862693 comment 11, we should remove the aPresContext and aFrame parameters from ThemeDrawsFocusForWidget.
Heck, might as well add MOZ_OVERRIDE while I'm touching these lines.
Comment on attachment 748533 [details] [diff] [review] patch I don't normally review /gfx or /widget code, but given the trivial nature of this bug and given that roc already rubber-stamped the idea by suggesting it, I'm happy to do a sanity-check review. So, r=me Technically, I think this needs sr, since it's a change to an interface. I bet roc would grant speedy sr. I'll take the liberty of sr?'ing him, to keep the process moving.
Attachment #748533 - Flags: superreview?(roc) → superreview+
Backed out, since it didn't compile: https://hg.mozilla.org/integration/mozilla-inbound/rev/abc9d00d1025 ../../../layout/forms/nsRangeFrame.cpp: In member function 'virtual void nsRangeFrame::BuildDisplayList(nsDisplayListBuilder*, const nsRect&, const nsDisplayListSet&)': ../../../layout/forms/nsRangeFrame.cpp:248:71: error: no matching function for call to 'nsITheme::ThemeDrawsFocusForWidget(nsPresContext*&, nsRangeFrame* const, const uint8_t&)' ../../dist/include/nsITheme.h:156:16: note: candidate is: virtual bool nsITheme::ThemeDrawsFocusForWidget(uint8_t) make: *** [nsRangeFrame.o] Error 1
Oops - I managed to conflict with a different patch I pushed a day earlier. Thanks for backing out. Re-pushed as: https://hg.mozilla.org/integration/mozilla-inbound/rev/7e5f9688566c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.