Like it title. After backing out patches from bug #748894 in bug #867343 bookmarks aren't visible in Bookmarks menu (using Nightly button). It works fine using old Bookmarks menu (with ALT key) and in Bookmarks button in toolbar.
6 years ago
An error appears in error Console when I click Bookmarks splitmenu. Error: ReferenceError: BookmarksMenuButton is not defined Source File: chrome://browser/content/browser.xul Line: 1
Yep, my bad - we didn't take into account https://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-appmenu.inc#222 when renaming BookmarksMenuButton BookmarkingUI.
Assignee: nobody → mconley
Created attachment 748646 [details] [diff] [review] Patch v1
Attachment #748646 - Flags: review?(mak77)
while there please also fix the 2 reportError in browser-places that reference BookmarksMenuButton
Ugh, I pushed without fixing the reportErrors. :/ I'll file a follow-up. Pushed to mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/01b4b6368014
Filed follow-up bug 871594 for the reportErrors.
status-firefox23: --- → affected
tracking-firefox23: --- → ?
Comment on attachment 748646 [details] [diff] [review] Patch v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 867343 User impact if declined: Bookmarks menu in AppMenu will not list any bookmarks. Testing completed (on m-c, etc.): Testing completed on m-c. Risk to taking this patch (and alternatives if risky): Extremely low risk. We failed to change an instance of BookmarksMenuButton to BookmarkingUI. String or IDL/UUID changes made by this patch: None.
Attachment #748646 - Flags: approval-mozilla-aurora?
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Attachment #748646 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox23: affected → fixed
6 years ago
Status: RESOLVED → VERIFIED
Verified as fixed with Firefox 23 beta 8, build ID: 20130722172257
status-firefox23: fixed → verified
QA Contact: manuela.muntean
2 years ago
a year ago
QA Contact: manuela.muntean → Virtual
You need to log in before you can comment on or make changes to this bug.