Closed Bug 871289 Opened 8 years ago Closed 8 years ago

netwerk/protocol/http spring cleaning

Categories

(Core :: Networking: HTTP, defect)

x86_64
Other
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

Attachments

(2 files)

Two patches:

1] standardize on MOZ_ASSERT() for fatal-debug-only checking. For some of the conversions from NS_ABORT_IF_FALSE(1,2) remove arg2 when it wasn't doing anything useful.

2] remove trailing whitespace " +$" .. more than my-share of this debris is due to my preferred editor config :)

https://tbpl.mozilla.org/?tree=Try&rev=556d9fcf8d7d

I wouldn't expect a line by line review of it.
Attached patch part 1 assert v0Splinter Review
Attachment #748559 - Flags: review?
Attachment #748560 - Flags: review?(jduell.mcbugs)
Attachment #748559 - Flags: review? → review?(jduell.mcbugs)
Blocks: 790388
Attachment #748559 - Flags: review?(jduell.mcbugs) → review+
Attachment #748560 - Flags: review?(jduell.mcbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/7400723d23bc
https://hg.mozilla.org/mozilla-central/rev/c87ddaff7aa4
Assignee: nobody → mcmanus
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.