Closed
Bug 871289
Opened 13 years ago
Closed 13 years ago
netwerk/protocol/http spring cleaning
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: mcmanus, Assigned: mcmanus)
References
Details
Attachments
(2 files)
|
216.24 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
|
353.62 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
Two patches:
1] standardize on MOZ_ASSERT() for fatal-debug-only checking. For some of the conversions from NS_ABORT_IF_FALSE(1,2) remove arg2 when it wasn't doing anything useful.
2] remove trailing whitespace " +$" .. more than my-share of this debris is due to my preferred editor config :)
https://tbpl.mozilla.org/?tree=Try&rev=556d9fcf8d7d
I wouldn't expect a line by line review of it.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #748559 -
Flags: review?
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #748560 -
Flags: review?(jduell.mcbugs)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #748559 -
Flags: review? → review?(jduell.mcbugs)
|
||
Updated•13 years ago
|
Attachment #748559 -
Flags: review?(jduell.mcbugs) → review+
|
|
||
Updated•13 years ago
|
Attachment #748560 -
Flags: review?(jduell.mcbugs) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7400723d23bc
https://hg.mozilla.org/mozilla-central/rev/c87ddaff7aa4
Assignee: nobody → mcmanus
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Depends on: 1091297
You need to log in
before you can comment on or make changes to this bug.
Description
•