871291 - Replace CSS selector -moz-locale-dir with chromedir selector inside pluginProblem.css

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Frank Wein [:mcsmurf]]

toolkit/themes/windows/mozapps/plugins/pluginProblem.css and toolkit/themes/osx/mozapps/plugins/pluginProblem.css both use this CSS rule for the plugin CTP UI:
 .closeIcon:-moz-locale-dir(rtl) {

This CSS selector does not work as -moz-locale-dir only works in XUL, see Bug 588996 and Bug 557221 (plugin UI specific bug). Plugin CTP UI is not a XUL document, it's a mix of XUL/HTML elements inside the HTML code of the webpage (at least I understood it that way). There's also -moz-dir since FF 18, but you need the dir attribute on some element for that one. The dir attribute on a XUL element does not seem to work, see Bug 871250 Comment 1 on that (see https://developer.mozilla.org/en-US/docs/Web/CSS/:dir for more info). I filed that bug on a similiar CSS issue and WONTFIXed it later as it was not solvable in the way I thought it could be solved.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Justin: See Comment 0 for an explanation of this patch, basically this patch replaces the CSS rule with the CSS rule like used in Bug 648675 (you reviewed the patch in that bug). I tested the patch by manually setting chromedir="rtl".

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 748561 [details] [diff] [review]
Patch

Sigh. We really out to either make it work everywhere, or remove it everywhere. :( But this is better than nothing.

Comment 3

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/ec0f5b78c99e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ec0f5b78c99e

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: SeaMonkey patch

Fixes the issue in the SeaMonkey Modern theme, same patch as for toolkit/ themes.

Comment 6

[Philip Chee]

Comment on attachment 751658 [details] [diff] [review]
SeaMonkey patch

looks reasonable r=me