Closed Bug 871291 Opened 7 years ago Closed 7 years ago

Replace CSS selector -moz-locale-dir with chromedir selector inside pluginProblem.css

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Details

(Keywords: rtl)

Attachments

(2 files)

toolkit/themes/windows/mozapps/plugins/pluginProblem.css and toolkit/themes/osx/mozapps/plugins/pluginProblem.css both use this CSS rule for the plugin CTP UI:
 .closeIcon:-moz-locale-dir(rtl) {

This CSS selector does not work as -moz-locale-dir only works in XUL, see Bug 588996 and Bug 557221 (plugin UI specific bug). Plugin CTP UI is not a XUL document, it's a mix of XUL/HTML elements inside the HTML code of the webpage (at least I understood it that way). There's also -moz-dir since FF 18, but you need the dir attribute on some element for that one. The dir attribute on a XUL element does not seem to work, see Bug 871250 Comment 1 on that (see https://developer.mozilla.org/en-US/docs/Web/CSS/:dir for more info). I filed that bug on a similiar CSS issue and WONTFIXed it later as it was not solvable in the way I thought it could be solved.
Attached patch PatchSplinter Review
Justin: See Comment 0 for an explanation of this patch, basically this patch replaces the CSS rule with the CSS rule like used in Bug 648675 (you reviewed the patch in that bug). I tested the patch by manually setting chromedir="rtl".
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #748561 - Flags: review?(dolske)
Comment on attachment 748561 [details] [diff] [review]
Patch

Sigh. We really out to either make it work everywhere, or remove it everywhere. :( But this is better than nothing.
Attachment #748561 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/ec0f5b78c99e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Attached patch SeaMonkey patchSplinter Review
Fixes the issue in the SeaMonkey Modern theme, same patch as for toolkit/ themes.
Attachment #751658 - Flags: review?(philip.chee)
Comment on attachment 751658 [details] [diff] [review]
SeaMonkey patch

looks reasonable r=me
Attachment #751658 - Flags: review?(philip.chee) → review+
You need to log in before you can comment on or make changes to this bug.