Closed
Bug 871321
Opened 11 years ago
Closed 11 years ago
Fix rooting hazards in the SMS code
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
2.76 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #748595 -
Flags: review?(tschneidereit)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 748595 [details] [diff] [review] Patch (v1) Review of attachment 748595 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/mobilemessage/src/MobileMessageCallback.cpp @@ +131,5 @@ > > AutoPushJSContext cx(sc->GetNativeContext()); > NS_ENSURE_TRUE(cx, NS_ERROR_FAILURE); > > + JS::RootedObject deleteArrayObj(cx, JS_NewArrayObject(cx, aSize, NULL)); So I guess this should be a JS::Rooted<JSObject*> or something like that, now. Because that's obviously much nicer.
Attachment #748595 -
Flags: review?(tschneidereit) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a51bca32e1dd
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a51bca32e1dd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•