871325 - Bookmark star icon is tiny and duplicated on Retina MacBook Pro

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: Tiny_stars_screenshot.png

Please see the attached screenshot.

This regression first appeared in Nightly build 2013-05-12. I believe this is a regression from bug 867343.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

@media (min-resolution: 2dppx) {
#star-button {
list-style-image: url("chrome://browser/skin/places/star-icons.png");

should be [e-mail]

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

I don't have a Retina display to try this on, so flying blind here.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I can verify with DOMi on the retina, I should have done that originally...

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 748825 [details] [diff] [review]
Patch v1

Review of attachment 748825 [details] [diff] [review]:
-----------------------------------------------------------------

it works!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Pushed to mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/a174d244334e

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 748825 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 867343

User impact if declined: OSX users with Retina displays will see a very strange grouping of icons where their star button used to be in their URL bar.

Testing completed (on m-c, etc.): mak tested this on a Retina Macbook on m-c.

Risk to taking this patch (and alternatives if risky): None - we simply failed to point some CSS at the right spritesheet.

String or IDL/UUID changes made by this patch: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a174d244334e

Comment 8

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c890c9a444f7

Comment 9

[u279076]

Matt, can you please verify this is fixed in Firefox 24 and 23 builds?

Comment 10

[Matt Wobensmith [:mwobensmith][:matt:]]

Confirmed issue on m-c 2013-05-12.
Confirmed fixed on FF23b4.
Confirmed fixed on FF24 2013-07-11.