Allow html_line_break as a supported HTML filter

RESOLVED WONTFIX

Status

()

Bugzilla
Testing Suite
--
trivial
RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: Simon Green, Assigned: Simon Green)

Tracking

Bug Flags:
approval -
approval4.4 -

Details

Attachments

(1 attachment)

549 bytes, patch
glob
: review+
Frédéric Buclin
: review-
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 748617 [details] [diff] [review]
v1 patch

Template toolkit provides a html_line_break filter
http://search.cpan.org/~abw/Template-Toolkit-2.14/lib/Template/Filters.pm#html_line_break

but Bugzilla does not recognise this as a valid filter.

Note: This is different to Bugzilla's html_linebreak filter.
(Assignee)

Updated

5 years ago
Assignee: testing → sgreen
Severity: normal → trivial
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → Bugzilla 4.4
(Assignee)

Updated

5 years ago
Attachment #748617 - Flags: review?(glob)
Comment on attachment 748617 [details] [diff] [review]
v1 patch

r=glob
Attachment #748617 - Flags: review?(glob) → review+
Flags: approval?
Flags: approval4.4?

Comment 2

5 years ago
Comment on attachment 748617 [details] [diff] [review]
v1 patch

The TT html_line_break filter only replaces newlines by <br>, but doesn't do any filtering at all, and so the content remains unfiltered, i.e. unsafe.

Our own html_linebreak filters content, and so is safe.

I cannot accept this patch.
Attachment #748617 - Flags: review-

Comment 3

5 years ago
html_line_break is not a HTML filter. What you want to write is:

[% foo FILTER html FILTER html_line_break %]
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: approval?
Flags: approval4.4?
Flags: approval4.4-
Flags: approval-
Resolution: --- → WONTFIX
Target Milestone: Bugzilla 4.4 → ---
You need to log in before you can comment on or make changes to this bug.