87139 - Search Msg UI: Descriptive text injured by Filter UI fix.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[laurel]

Using june21 commercial trunk build

The search messages UI now has descriptive text above the criteria section which
isn't correct in relation to the changed radio button text.  I believe this
happened as a result of the fix for filter ui - bug 82773.
 
Text previously worked together, was displayed as:
"Search for messages which:"  (descriptive text above criteria section)
"match ALL of the following conditions"  (radio button text)
"match at least ONE of the following conditions" (radio button text)

NOW, after the filter UI fix, search UI reads:
"Search for messages which:"
"All of the following"
"Any of the following"

Fix needed by RTM.

Comment 1

[Navin Gupta]

hwaara, why did you change this ?

Comment 2

[Håkan Waara]

Why I changed it? Jglick, mpt, sspitzer, hewitt, alex bishop and I agreed that
my rouch cleanup was good. If you ask jglick, it is supposed to be in the spec.

I can fix this -- no problem, as long as you're friendly.

Comment 3

[Håkan Waara]

Proposed solution: replace the current descriptive text with "Search for
messages which match".  That will make the sentence flow correctly.

Comment 4

[jglick]

"Search for messages which match:"

"All of the following"
"Any of the following"

Comment 5

[jglick]

Attachment: example

Comment 6

[Håkan Waara]

Attachment: fix

Comment 7

[Håkan Waara]

Now also consistent with Filters UI which uses "For incoming messages that
match:" (is the that/which inconsistency correct?).


Laurel or Jglick, wanna review the wording fix?

Comment 8

[Alex Bishop]

I'm pretty certain that "Search for messages which match" should be ""Search for
messages that match". The rule of thumb I've always used is that it's "which" if
it follows a comma, and "that" if it doesn't.

Comment 9

[jglick]

OK, "that" it is.

your fix looks fine to me, but being that i'm not an engineer, you might wanna 
have someone else check it. thanks for the fix.

Comment 10

[(not reading, please use [e-mail] instead)]

it sounds like jglick wants to go with: "Search for messages that match:"

please attach a new patch.

Comment 11

[Håkan Waara]

Attachment: new fix

Comment 12

[Håkan Waara]

Can I get a r= and sr= for this simple fix.

Comment 13

[Navin Gupta]

r=naving

Comment 14

[(not reading, please use [e-mail] instead)]

sr=sspitzer

jglick, please update the spec.

Comment 15

[jglick]

will do.

Comment 16

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9.2.
(on behalf of drivers)

Comment 17

[Håkan Waara]

fix checked in before carpool

Comment 18

[laurel]

OK using jun22 commercial trunk builds.