871425 - [Dialer] When very long string is saved in contacts, string is represented abnormally in call screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P3)

Description

[Leo]

1. Title : When very long string is saved in contacts, string is represented abnormally in call screen
2. Precondition : contacts >> add contacs
/////////
Name : aa
mobile
phone  : [phone]
Carrier : dndnwkwwkdndnwkwwkdndnwkwwkdndnwkwwkfjfjfjfjfjfjflwlwlwlwwlwwwwwwdndnwkwwkkkk(very long string)
/////////
Done
3. Tester's Action : aa Outgoing call 
4. Detailed Symptom : string is represented abnormally 
5. Expected :  string is normally represented or "dndnwkwwkdndnwk... "
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train : Reproduced
8. Gaia Revision : 5cbb19e4bb78a7ad879fbe4b9a841e1c35714f5c
9 Personal email id : [e-mail]

Comment 1

[Leo]

Attachment: String is divided

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

This is a corner case, but the UX is not attractive here, so ni? on UX team to check that we're meeting specs on contact display in outbound calling.  Also I'm concerned that the screenshot provided shows 'mobile,' in the contact info and not the phone number from that field.  Is this an inconsistency between comment 0 and what was actually entered or do we have another bug here on not showing the phone number - qawanted to try the STR as comment 0 lists them and see if the screenshot is the same.

Comment 3

[pallavi]

Attachment: long string for the contact works fine

Comment 4

[pallavi]

This issue is not reproducing on both Inari and Unagi. Screen shot attached in the Comment3

Inari Build ID: 20130513070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/50726fbdc25e
Gaia: a503d9a1d0a588f3689243c1ddc0f016ede51b9d

Unagi Build ID: 20130513070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/50726fbdc25e
Gaia: a503d9a1d0a588f3689243c1ddc0f016ede51b9d

Comment 5

[Leo]

I think you save string in "Name" section.
But, in this case, save string in "Carrier" section.
Check this please.

Comment 6

[pallavi]

The same issue is still reproducing on Inari and Unagi.

Tested by saving long string in the "Carrier" section.

Inari Build ID: 20130513070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/50726fbdc25e
Gaia: a503d9a1d0a588f3689243c1ddc0f016ede51b9d

Unagi Build ID: 20130513070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/50726fbdc25e
Gaia: a503d9a1d0a588f3689243c1ddc0f016ede51b9d

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Hi Mihail! ;) Are you currently working on this bug or would you like me to take care of it? I know where to include the needed changes :-) If you would like me to take care of it, please do not hesitate to directly assign it to me. Thanks!

Comment 8

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Hi gtorodelvalle, I am planning to work on it this evening (had some other patches in my queue by now). Thanks for asking, and sorry I'm not letting it go :)

Comment 9

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #9803 - Truncate additional contact info

Simple CSS fix when displaying additional contact info.

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 750131 [details]
Pull Request #9803 - Truncate additional contact info

thanks!

Comment 11

[Stephany Wilkes]

Reassigning from general UX to Francis, for the quick UI check in comment 2. Looks like the rest is done.

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Etienne! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/c7f7636510a3a62e21d81107fd4e3ba7bb501854

Regarding the UI question from comment 2, I would suggest a follow-up bug to be filed if instead of 'mobile' the phone number should be shown. I would be more than happy to take it.

Comment 13

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 750131 [details]
Pull Request #9803 - Truncate additional contact info

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): OnCall screen > additional info
User impact if declined: Low (if carrier name is longer then the screen width it is not truncated)
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: No

Comment 14

[Alex Keybl [:akeybl]]

Comment on attachment 750131 [details]
Pull Request #9803 - Truncate additional contact info

Minor width change and low risk - approving.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted c7f7636510a3a62e21d81107fd4e3ba7bb501854 to:
v1-train: 8929c1b60f84fd0bd06510bbb477a6c7762d9747