Closed Bug 871464 Opened 6 years ago Closed 6 years ago
Master password menu isn't updated after enable/disable the password
Nightly 23.0a1 (2013-05-12) Device: Nexus 4 (4.2.2), HTC Desire Z (2.3.3) Steps to reproduce: 1.Set Master Password. Expected results: The Use Master Password option is checked and after accessing the "Use master password" again the "Remove Master Password" pop-up appears. Actual results: The Use Master Password option isn't checked and after accessing the "Use master password" again the "Create Master Password" pop-up appears. After leaving and re-entering the settings menu, Use Master Password option is updated.
Please find a regression range.
The regression window for this issue is: good build: 2013/05/23 bad build 2013/05/24 possible push-log: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=acf388eaf9e9&tochange=fef5f202b2dc
I'm not sure what would have broken this, and am even a bit less sure why it was working. My original patches relied on the fact that PreferencesScreen registered for Preferences:Data while it was alive, and just sent back the updated pref from MasterPassword.js when it changed. That was all removed in bug 753312 (in fact, you can see it dump an error when the message comes up from Masterpassword.js), but continued working because we were hitting onWindowFocusChanged when the dialog appears/disappears and we refetch all the prefs. I think we should probably observe the prefs here and pick up changes to any of them...
Attachment #749078 - Flags: review?(margaret.leibovic) → review+
Made a little mistake fixing the forEach bit. Fixed: https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f6eb6cde95
Comment on attachment 749078 [details] [diff] [review] Patch v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 773535 User impact if declined: Pref checkbox isn't updated when you change it Testing completed (on m-c, etc.): Landed on mc today Risk to taking this patch (and alternatives if risky): medium low risk. Changes the pref listener we already had to observe pref changes. Alters some js code to use the new observer stuff String or IDL/UUID changes made by this patch: None.
Attachment #749078 - Flags: approval-mozilla-aurora?
Comment on attachment 749078 [details] [diff] [review] Patch v1 Extra bake time on Aurora likely won't uncover regressions anyway. Approving for uplift.
Attachment #749078 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Verified fixed on Nightly 23.0a1 (2013-05-19) and Aurora 23.0a2 (2013-05-19) Device: Nexus 4 (4.2.2)
You need to log in before you can comment on or make changes to this bug.