[customize] homescreen customization not applied to page swipe

RESOLVED FIXED

Status

Firefox OS
Gaia::Homescreen
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gasolin@mozilla.com, Assigned: gasolin@mozilla.com)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [TAIPEI_FND_TRACKING], [customization])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
set 

"swipe": 
{
"threshold":0.2,
"friction":0.1,
"transition_duration":100
}


in customer distribution does not change the threshold of page swipe.
Whiteboard: [TAIPEI_FND_TRACKING]
(Assignee)

Comment 1

5 years ago
It appears homescreen.js applied above settings, but grid.js does not
Whiteboard: [TAIPEI_FND_TRACKING]
(Assignee)

Updated

5 years ago
Assignee: nobody → gasolin
Whiteboard: TAIPEI_FND_TRACKING
(Assignee)

Comment 2

5 years ago
Created attachment 748781 [details]
pull request redirect to github

Fix the build script that can pass swipe options from GAIA_DISTRIBUTION_DIR

For customization, most options are passed from homescreen.js::GridManager.init. So grid.js::default is removed.

Also fix legacy plenty of lint errors :dizzy_face:
The left 3 lint errors are due to bookmark json, which use base64 icon (1k+ long)
Attachment #748781 - Flags: review?(timdream)
Comment on attachment 748781 [details]
pull request redirect to github

redirect review to home screen owner.
Attachment #748781 - Flags: review?(timdream) → review?(crdlc)
Whiteboard: TAIPEI_FND_TRACKING → [TAIPEI_FND_TRACKING]

Updated

5 years ago
Whiteboard: [TAIPEI_FND_TRACKING] → [TAIPEI_FND_TRACKING], [customization]
Some comment on Github, thanks a lot
Status: NEW → ASSIGNED
(Assignee)

Comment 5

5 years ago
Cristian,

as comment #2, For customization, most options(swipe, tapThreshold) are passed from homescreen.js::GridManager.init. So grid.js::default is removed.

For defaults options, only css selector options are unique in grid.js, thus I'd assign those css selector options in gm_init and remove the defaults var.
But... selectors can be defined by the caller

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/homescreen.js#L29

and you are deleting this feature
(Assignee)

Comment 7

5 years ago
updated to add defaults back in grid.js, 
and limit lint fix to homescreen related settings
Comment on attachment 748781 [details]
pull request redirect to github

Please review some minor change in github, for the rest it is perfect. Thanks a lot
Attachment #748781 - Flags: review?(crdlc) → review+
(Assignee)

Comment 9

5 years ago
Cristian, Thanks for review.
I've update those glitches.
Please read my last comment and merge it when you want, thanks for the great job
(Assignee)

Comment 11

5 years ago
Cristian, I modified the patch at night, just want to do the merge while in clear mind :)

merged into master-gaia e882f5d6649ad22dbe0f8e8e8726c84cce2a2d4d
thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.