Closed Bug 871491 Opened 9 years ago Closed 9 years ago
CSP dev console warnings and errors look the same
freddyb: yes I agree! I started working on this when I wrote the original patch, but after some discussion we agreed it was not necessary and was holding up landing the key functionality. All that had to be done is edit webconsole.png to add the icons and webconsole.css to add CSS rules to choose the correct offsets within the PNG sprite (in browser/themes/*/devtools). I will take a crack at this right now.
Assignee: nobody → grobinson
Status: NEW → ASSIGNED
This patch adds icons to differentiate between errors and warnings in the Web Console's security pane. You can easily see them in action by running browser/devtools/webconsole/test/browser_webconsole_bug_821877_csp_errors.js (you will see warnings for the deprecated CSP errors, with the exclamation-point-in-a-triangle warning icon) or content/base/test/test_mixed_content_blocker.html (blocked mixed content resources are errors, and will have red x icons).
Tested and looks good!
Attachment #749053 - Flags: feedback?(fbraun) → feedback+
Comment on attachment 749053 [details] [diff] [review] Patch 1 Review of attachment 749053 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks!
Attachment #749053 - Flags: review?(mihai.sucan) → review+
Target Milestone: --- → mozilla24
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.